You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Joris Verschoor (JIRA)" <de...@myfaces.apache.org> on 2005/11/09 13:12:19 UTC
[jira] Created: (MYFACES-801) RegExprValidatorTag patch: message attribute
RegExprValidatorTag patch: message attribute
--------------------------------------------
Key: MYFACES-801
URL: http://issues.apache.org/jira/browse/MYFACES-801
Project: MyFaces
Type: Improvement
Reporter: Joris Verschoor
Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
<h:inputText id="name" value="#{bean.name}" required="true">
<t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
</h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Joris Verschoor (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ]
Joris Verschoor updated MYFACES-801:
------------------------------------
Attachment: ValidateRegExprTag.class
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java, ValidateRegExprTag.class
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (TOMAHAWK-169) add message attribute to all
validators
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-169?page=all ]
Mike Kienenberger closed TOMAHAWK-169:
--------------------------------------
Fix Version: 1.1.2-SNAPSHOT
Resolution: Fixed
Converted existing tomahawk and sandbox validators.
At some point, the standard JSF validators should be cloned to tomahawk so they could also inherit this behavior.
> add message attribute to all validators
> ---------------------------------------
>
> Key: TOMAHAWK-169
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-169
> Project: MyFaces Tomahawk
> Type: Improvement
> Components: Validators
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Priority: Minor
> Fix For: 1.1.2-SNAPSHOT
> Attachments: RegExprValidator.java.patch.txt, ValidateRegExprTag.java.patch.txt, tomahawk_validate_regexpr_attributes.xml.patch.txt, validateRegExpr.xml.patch.txt
>
> Added a message attribute to the rexexvalidator [and all other validators -mlk]. If the message attribute is set, the message attribute value will be used as the error message key instead. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-801) add message attribute to all
validators
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ]
Mike Kienenberger updated MYFACES-801:
--------------------------------------
> add message attribute to all validators
> ---------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces Core
> Type: Improvement
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Priority: Minor
>
> Added a message attribute to the rexexvalidator [and all other validators -mlk]. If the message attribute is set, the message attribute value will be used as the error message key instead. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-169) add message attribute to all
validators
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-169?page=comments#action_12368421 ]
Mike Kienenberger commented on TOMAHAWK-169:
--------------------------------------------
Patch applied for RegExp validator. Still needed for others.
> add message attribute to all validators
> ---------------------------------------
>
> Key: TOMAHAWK-169
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-169
> Project: MyFaces Tomahawk
> Type: Improvement
> Components: Validators
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Priority: Minor
> Attachments: RegExprValidator.java.patch.txt, ValidateRegExprTag.java.patch.txt, tomahawk_validate_regexpr_attributes.xml.patch.txt, validateRegExpr.xml.patch.txt
>
> Added a message attribute to the rexexvalidator [and all other validators -mlk]. If the message attribute is set, the message attribute value will be used as the error message key instead. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Joris Verschoor (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ]
Joris Verschoor updated MYFACES-801:
------------------------------------
Attachment: RegExprValidator.java
Sorry, no patch, just modified sourcecode.
Added message attribute.
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-801) RegExprValidatorTag patch: message
attribute
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ]
Mike Kienenberger updated MYFACES-801:
--------------------------------------
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces Core
> Type: Improvement
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Attachments: RegExprValidator.java, ValidateRegExprTag.class, ValidateRegExprTag.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Joris Verschoor (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ]
Joris Verschoor updated MYFACES-801:
------------------------------------
Attachment: ValidateRegExprTag.java
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java, ValidateRegExprTag.class, ValidateRegExprTag.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=comments#action_12357272 ]
Mike Kienenberger commented on MYFACES-801:
-------------------------------------------
Yes, we should add a "message" tag to all validators, when possible.
There was talk of adding this to JSF 1.2, but I don't think it made it in. Instead, they were looking at a "converterMessage" and "validatorMessage" added to UIInput components.
https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=81
I've implemented my CompareToValidator with such an attribute as well.
http://cvs.sourceforge.net/viewcvs.py/jsf-comp/componentsandbox/src/java/org/apache/myfaces/custom/comparetovalidator/CompareToValidator.java?view=markup
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java, ValidateRegExprTag.class, ValidateRegExprTag.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Joris Verschoor (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=comments#action_12357124 ]
Joris Verschoor commented on MYFACES-801:
-----------------------------------------
Also in the TLD a non-required attribute 'message' should be added.
The files could contain compile errors. We have a different coding style, and implemented this in our own package, so it was easier to paste some stuff in.
btw, why does myfaces mix coding styles????
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java, ValidateRegExprTag.class, ValidateRegExprTag.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-169) add message attribute to all
validators
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-169?page=comments#action_12368398 ]
Mike Kienenberger commented on TOMAHAWK-169:
--------------------------------------------
Removed all attachments. Files were not in patch format. Code in CompareToValidator is probably a better basis in any case.
> add message attribute to all validators
> ---------------------------------------
>
> Key: TOMAHAWK-169
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-169
> Project: MyFaces Tomahawk
> Type: Improvement
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Priority: Minor
>
> Added a message attribute to the rexexvalidator [and all other validators -mlk]. If the message attribute is set, the message attribute value will be used as the error message key instead. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-801) RegExprValidatorTag patch: message attribute
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-801?page=comments#action_12357266 ]
Martin Marinschek commented on MYFACES-801:
-------------------------------------------
This is not the same way as with our other validators, right?
If we add this, we should also add this for all other validators.
regards,
Martin
> RegExprValidatorTag patch: message attribute
> --------------------------------------------
>
> Key: MYFACES-801
> URL: http://issues.apache.org/jira/browse/MYFACES-801
> Project: MyFaces
> Type: Improvement
> Reporter: Joris Verschoor
> Attachments: RegExprValidator.java, ValidateRegExprTag.class, ValidateRegExprTag.java
>
> Added a message attribute to the rexexvalidator. If the attribute is set, that will be used as the errormessage. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-169) add message attribute to all
validators
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-169?page=all ]
Mike Kienenberger updated TOMAHAWK-169:
---------------------------------------
> add message attribute to all validators
> ---------------------------------------
>
> Key: TOMAHAWK-169
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-169
> Project: MyFaces Tomahawk
> Type: Improvement
> Components: Validators
> Reporter: Joris Verschoor
> Assignee: Mike Kienenberger
> Priority: Minor
> Attachments: RegExprValidator.java.patch.txt, ValidateRegExprTag.java.patch.txt, tomahawk_validate_regexpr_attributes.xml.patch.txt, validateRegExpr.xml.patch.txt
>
> Added a message attribute to the rexexvalidator [and all other validators -mlk]. If the message attribute is set, the message attribute value will be used as the error message key instead. For example:
> <h:inputText id="name" value="#{bean.name}" required="true">
> <t:validateRegExpr message="#{errors['NameNoNumbers']}" pattern="\D*" />
> </h:inputText>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira