[jira] [Updated] (OFBIZ-6781) Incorrect order adjustment after order item is cancelled

["Suraj Khurana (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suraj Khurana updated OFBIZ-6781:
---------------------------------
    Attachment: OFBIZ-6781-trunk.patch

Attaching patch with proper fix.
Here two changes are done inside recreateOrderAdjustments service.
-While calculating newOrderAdjustmentTotal we should only consider cart adjustments with No orderAdjustmentId, so adding condition for the same.
-While calculating existingOrderAdjustmentTotal, adding check for orderAdjustmentTypeId instead of productPromoId, so that Promotion adjustments due to order change will also be included in the same.

> Incorrect order adjustment after order item is cancelled
> --------------------------------------------------------
>
>                 Key: OFBIZ-6781
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6781
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Vyom Jain
>         Attachments: OFBIZ-6781-trunk.patch
>
>
> Steps to replicate (tested on trunk at r1721093) - 
> 1. Make sure promotion https://localhost:8443/catalog/control/EditProductPromo?productPromoId=9011 is enabled.
> 2. Create a sales order after adding to cart 1 x GZ-1001 @ $25.99 & 1 x GZ-1000 @ $15.99
> 3. order view screen shows Total Other Order Adjustments as -$4.2, which is correct.
> 4. Cancel 1 x GZ-1001 @ $25.99
> 5. Reload order view screen.
> Observed - 
> 1. order view screen shows Total Other Order Adjustments as -($4.20 + $1.6) = -$5.8
> Expected - 
> 1. order view screen should show Total Other Order Adjustments as -$1.6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)