You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andera Del Bene (JIRA)" <ji...@apache.org> on 2010/10/01 21:14:36 UTC
[jira] Created: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
------------------------------------------------------------------------------------------
Key: WICKET-3087
URL: https://issues.apache.org/jira/browse/WICKET-3087
Project: Wicket
Issue Type: Bug
Components: wicket, wicket-extensions
Affects Versions: 1.4.12
Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
Reporter: Andera Del Bene
We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
with no problem. Inside form we have one link that opens a ModalWindow via ajax.
This window contains another wicket form which is submitted by a IndicatingAjaxButton.
The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
"org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
is not visible".
It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Andera Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andera Del Bene updated WICKET-3087:
------------------------------------
Attachment: BugQuickStart.zip
Quickstart Eclipse project. To reproduce bug see instructions inside page.
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Attachments: BugQuickStart.zip
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918659#action_12918659 ]
Hudson commented on WICKET-3087:
--------------------------------
Integrated in Apache Wicket 1.4.x #190 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/190/])
WICKET-3087 Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
Update the DOM for the modal window content when closing it - remove the content.
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Assignee: Martin Grigorov
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: BugQuickStart.zip, patch.txt
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918675#action_12918675 ]
Hudson commented on WICKET-3087:
--------------------------------
Integrated in Apache Wicket 1.5.x #384 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/384/])
WICKET-3087 Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
Update the DOM for the modal window content when closing it - remove the content.
merge r1005201 from 1.4.x
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Assignee: Martin Grigorov
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: BugQuickStart.zip, patch.txt
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917568#action_12917568 ]
Pedro Santos commented on WICKET-3087:
--------------------------------------
The modal window close method just sends to browser an javascript that closes the modal window, but maintain it's component html.
There is even some javascript on this close callback that reattach the component DOM on it's original parent.
I just can't see a good reason to maintain this invisible component DOM, since when user invoke the modal show method, it will to be rebuild anyway. In fact this is causing the stated problem. The user type the "enter" key at an form field, and the form visitor looking for the submit button reach an invisible button: the same button at the hidden modal window component DOM, that was listed in the submitted form parameters.
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Attachments: BugQuickStart.zip
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3087.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
1.4.13
Fixed.
Thanks for the patch Pedro!
Looking at Firebug HTML console the DOM entries for the modal window are completely cleaned now. I think there is nothing more to do.
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Assignee: Martin Grigorov
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: BugQuickStart.zip, patch.txt
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3087:
---------------------------------------
Assignee: Martin Grigorov
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Assignee: Martin Grigorov
> Attachments: BugQuickStart.zip, patch.txt
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3087) Form inside ModalWindow causes
'Submit Button not visible' exception in parent page's form
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3087:
---------------------------------
Attachment: patch.txt
IMO the javascript codification to restore the component DOM should be removed as well. Let me know if I'm going in the right direction.
> Form inside ModalWindow causes 'Submit Button not visible' exception in parent page's form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3087
> URL: https://issues.apache.org/jira/browse/WICKET-3087
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.4.12
> Environment: Problem seems affect Firefox (ver 3.6.10) and Opera (ver 10.62). Chrome it's ok (ver. 6).
> Reporter: Andera Del Bene
> Attachments: BugQuickStart.zip, patch.txt
>
>
> We've got a page with a wicket form and just one submit button. When we press return key in a form field the form is submitted
> with no problem. Inside form we have one link that opens a ModalWindow via ajax.
> This window contains another wicket form which is submitted by a IndicatingAjaxButton.
> The problem comes when we hit return key on parent page's form after we've opened and closed ModalWindow. In this case we get the following exception:
> "org.apache.wicket.WicketRuntimeException: Submit Button <window's button name>
> is not visible".
> It seems that even if we have closed window, its submit button is still be active.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.