You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/06/18 22:45:43 UTC
[jira] [Commented] (THRIFT-1573) Error on TNonblockingServer
constructor
[ https://issues.apache.org/jira/browse/THRIFT-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396236#comment-13396236 ]
Hudson commented on THRIFT-1573:
--------------------------------
Integrated in Thrift #501 (See [https://builds.apache.org/job/Thrift/501/])
THRIFT-1631 Fix C++ server constructor typos
Patch: Andrew Cox
THRIFT-1573 Error on TNonblockingServer constructor
Patch: Denis (Revision 1351472)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1351472
Files :
* /thrift/trunk/lib/cpp/src/thrift/server/TServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadPoolServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadedServer.h
> Error on TNonblockingServer constructor
> ---------------------------------------
>
> Key: THRIFT-1573
> URL: https://issues.apache.org/jira/browse/THRIFT-1573
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.8
> Reporter: Denis
> Labels: TNonblockingServer
>
> If the TNonblockingServer is to construct:
> TNonblockingServer server(processorFactory, protocolFactory, port, threadManager);
> the compiler generates an error:
> error C2664: apache::thrift::server::TServer::TServer(const apache::thrift::server::TServer &): cannot convert parameter 1 from "const boost::shared_ptr<T>" to "const apache::thrift::server::TServer &" e:\develop\cpp\lib\thrift\src\server\tnonblockingserver.h 264
> patch:
> {noformat}
> Index: TServer.h
> ===================================================================
> --- TServer.h (revision 1337971)
> +++ TServer.h (working copy)
> @@ -142,7 +142,7 @@
>
> protected:
> template<typename ProcessorFactory>
> - TServer(const boost::shared_ptr<TProcessorFactory>& processorFactory,
> + TServer(const boost::shared_ptr<ProcessorFactory>& processorFactory,
> THRIFT_OVERLOAD_IF(ProcessorFactory, TProcessorFactory)):
> processorFactory_(processorFactory) {
> setInputTransportFactory(boost::shared_ptr<TTransportFactory>(
> @@ -166,7 +166,7 @@
> }
>
> template<typename ProcessorFactory>
> - TServer(const boost::shared_ptr<TProcessorFactory>& processorFactory,
> + TServer(const boost::shared_ptr<ProcessorFactory>& processorFactory,
> const boost::shared_ptr<TServerTransport>& serverTransport,
> THRIFT_OVERLOAD_IF(ProcessorFactory, TProcessorFactory)):
> processorFactory_(processorFactory),
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira