[GitHub] [iceberg] rdblue commented on a diff in pull request #5656: Deprecations for 1.0 release: ORC properties

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5656:
URL: https://github.com/apache/iceberg/pull/5656#discussion_r956788769


##########
orc/src/main/java/org/apache/iceberg/orc/ORC.java:
##########
@@ -86,9 +85,6 @@
 @SuppressWarnings("checkstyle:AbbreviationAsWordInName")
 public class ORC {
 
-  /** @deprecated use {@link TableProperties#ORC_WRITE_BATCH_SIZE} instead */
-  @Deprecated private static final String VECTOR_ROW_BATCH_SIZE = "iceberg.orc.vectorbatch.size";

Review Comment:
   While we don't want people using this, does it make sense to ever actually remove it? It could cause behavior changes that we don't really need to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org