You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/20 11:32:44 UTC
[GitHub] [spark] Yikun commented on a change in pull request #32604: [SPARK-35458][BUILD] Use ` > /dev/null` to replace `-q` in shasum
Yikun commented on a change in pull request #32604:
URL: https://github.com/apache/spark/pull/32604#discussion_r636017195
##########
File path: build/mvn
##########
@@ -78,7 +78,7 @@ install_app() {
echo " ${local_tarball}" >> ${local_checksum} # two spaces + file are important!
# Assuming SHA512 here for now
echo "Veryfing checksum from ${local_checksum}" 1>&2
- if ! shasum -a 512 -q -c "${local_checksum}" ; then
+ if ! shasum -a 512 -c "${local_checksum}" > /dev/null 2>&1 ; then
Review comment:
Make sense, just let wrong message print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org