[GitHub] [nifi] kevdoran edited a comment on pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

[GitBox <gi...@apache.org>]

kevdoran edited a comment on pull request #4933:
URL: https://github.com/apache/nifi/pull/4933#issuecomment-808391298


   @gruselglatz - There is no reason this updated minifi coming from the nifi code base should not be compatible with the minifi-c2 server. I took a closer look, and now realize I was mistaking this implementation, which acts as a server for the PullHttpChangeIngestor, with [the implementation on this branch](https://github.com/apache/nifi-minifi/tree/minifi-c2-server/minifi-c2), which was a WIP to update the server based on the aforementioned [C2 Protocol](https://cwiki.apache.org/confluence/display/MINIFI/C2+Design).
   
   Given that this updated minifi retains the Change Investor capabilities, I'm all for keeping the corresponding server, which I agree is useful. (Note - I'm still not sure how actively maintained/patched that server is, so users should be aware of that.)
   
   In the future, I would be in favor of adding a Java client implementation of the [C2 Protocol]((https://cwiki.apache.org/confluence/display/MINIFI/C2+Design)) in this project to be shared be nifi and minifi, which is compatible with the implememtation in `nifi-minifi-cpp`. We should also add a new C2 server implementation for this protocol which could be shared by nifi, minifi, and minifi-cpp, to align all these different flow runtime engines with the same C2 capabilities.
   
   That should not be a consideration for this PR, merely something we could build upon this updated minifi. @mattyb149 - sorry for the back and forth on this, but if the plan is to sunset the nifi-minifi repository, then I do think we should retain that minifi-c2 module here, or else find another home for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org