You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/07/07 13:17:02 UTC

[PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

dependabot[bot] opened a new pull request, #6227:
URL: https://github.com/apache/texera/pull/6227

   Bumps org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0.
   
   
   [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.hadoop:hadoop-common&package-manager=sbt&previous-version=3.4.3&new-version=3.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   <details>
   <summary>Dependabot commands and options</summary>
   <br />
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
   - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
   
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6227:
URL: https://github.com/apache/texera/pull/6227#issuecomment-4904264152

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #6227:
URL: https://github.com/apache/texera/pull/6227#discussion_r3549926055


##########
amber/build.sbt:
##########
@@ -158,7 +158,7 @@ val luceneDependencies = Seq(
 
 /////////////////////////////////////////////////////////////////////////////
 // Hadoop related
-val hadoopVersion = "3.4.3"
+val hadoopVersion = "3.5.0"

Review Comment:
   Good catch — done. I bumped `hadoop-common` and `hadoop-mapreduce-client-core` in `common/workflow-core/build.sbt` to 3.5.0 as well, so every module now resolves a single Hadoop version and there's no cross-module eviction. hdfs-client / yarn-* follow transitively at 3.5.0, and the per-service LICENSE-binary/NOTICE files are re-synced.



##########
amber/NOTICE-binary:
##########
@@ -503,6 +503,201 @@ which can be obtained from
 
   https://bitbucket.org/eunjeon/mecab-ko-dic/downloads/mecab-ko-dic-2.0.3-20170922.tar.gz
 
+--------------------------------------------------------------------------------
+com.sun.istack.istack-commons-runtime
+--------------------------------------------------------------------------------
+
+# Notices for Eclipse Implementation of JAXB
+
+This content is produced and maintained by the Eclipse Implementation of JAXB
+project.
+
+* Project home: https://projects.eclipse.org/projects/ee4j.jaxb-impl
+
+## Trademarks
+
+Eclipse Implementation of JAXB is a trademark of the Eclipse Foundation.
+
+## Copyright
+
+All content is the property of the respective authors or their employers. For
+more information regarding authorship of content, please consult the listed
+source code repository logs.
+
+## Declared Project Licenses
+
+This program and the accompanying materials are made available under the terms
+of the Eclipse Distribution License v. 1.0 which is available at
+http://www.eclipse.org/org/documents/edl-v10.php.
+
+SPDX-License-Identifier: BSD-3-Clause

Review Comment:
   This block came from Hadoop 3.5.0's new Jersey 2.x / glassfish JAXB web stack, which Texera doesn't use — we only pull hadoop as a filesystem client. I've excluded that whole stack, so the glassfish JAXB runtime + istack-commons jars (and this NOTICE block) are no longer bundled. For the record it's EDL 1.0 (== BSD-3-Clause, ASF Category A), so it would have been fine either way, but dropping it keeps the dist minimal.



##########
amber/NOTICE-binary:
##########
@@ -503,6 +503,201 @@ which can be obtained from
 
   https://bitbucket.org/eunjeon/mecab-ko-dic/downloads/mecab-ko-dic-2.0.3-20170922.tar.gz
 
+--------------------------------------------------------------------------------
+com.sun.istack.istack-commons-runtime
+--------------------------------------------------------------------------------
+
+# Notices for Eclipse Implementation of JAXB
+
+This content is produced and maintained by the Eclipse Implementation of JAXB
+project.
+
+* Project home: https://projects.eclipse.org/projects/ee4j.jaxb-impl
+
+## Trademarks
+
+Eclipse Implementation of JAXB is a trademark of the Eclipse Foundation.
+
+## Copyright
+
+All content is the property of the respective authors or their employers. For
+more information regarding authorship of content, please consult the listed
+source code repository logs.
+
+## Declared Project Licenses
+
+This program and the accompanying materials are made available under the terms
+of the Eclipse Distribution License v. 1.0 which is available at
+http://www.eclipse.org/org/documents/edl-v10.php.
+
+SPDX-License-Identifier: BSD-3-Clause
+
+## Source Code
+
+The project maintains the following source code repositories:
+
+* https://github.com/eclipse-ee4j/jaxb-ri
+* https://github.com/eclipse-ee4j/jaxb-istack-commons
+* https://github.com/eclipse-ee4j/jaxb-dtd-parser
+* https://github.com/eclipse-ee4j/jaxb-fi
+* https://github.com/eclipse-ee4j/jaxb-stax-ex
+* https://github.com/eclipse-ee4j/jax-rpc-ri
+
+## Third-party Content
+
+This project leverages the following third party content.
+
+Apache Ant (1.10.2)
+
+* License: Apache-2.0 AND W3C AND LicenseRef-Public-Domain
+
+Apache Ant (1.10.2)
+
+* License: Apache-2.0 AND W3C AND LicenseRef-Public-Domain
+
+Apache Felix (1.2.0)
+
+* License: Apache License, 2.0
+
+args4j (2.33)
+
+* License: MIT License
+
+dom4j (1.6.1)
+
+* License: Custom license based on Apache 1.1
+
+file-management (3.0.0)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/shared/file-management/
+* Source:
+   https://svn.apache.org/viewvc/maven/shared/tags/file-management-3.0.0/
+
+JUnit (4.12)
+
+* License: Eclipse Public License
+
+JUnit (4.12)
+
+* License: Eclipse Public License
+
+maven-compat (3.5.2)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/ref/3.5.2/maven-compat/
+* Source:
+   https://mvnrepository.com/artifact/org.apache.maven/maven-compat/3.5.2
+
+maven-core (3.5.2)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/ref/3.5.2/maven-core/index.html
+* Source: https://mvnrepository.com/artifact/org.apache.maven/maven-core/3.5.2
+
+maven-plugin-annotations (3.5)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/plugin-tools/maven-plugin-annotations/
+* Source:
+   https://github.com/apache/maven-plugin-tools/tree/master/maven-plugin-annotations
+
+maven-plugin-api (3.5.2)
+
+* License: Apache-2.0
+
+maven-resolver-api (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-api (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-connector-basic (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-impl (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-spi (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-transport-file (1.1.1)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/resolver/maven-resolver-transport-file/
+* Source:
+   https://github.com/apache/maven-resolver/tree/master/maven-resolver-transport-file
+
+maven-resolver-util (1.1.1)
+
+* License: Apache-2.0
+
+maven-settings (3.5.2)
+
+* License: Apache-2.0
+* Source:
+   https://mvnrepository.com/artifact/org.apache.maven/maven-settings/3.5.2
+
+OSGi Service Platform Core Companion Code (6.0)
+
+* License: Apache License, 2.0
+
+plexus-archiver (3.5)
+
+* License: Apache-2.0
+* Project: https://codehaus-plexus.github.io/plexus-archiver/
+* Source: https://github.com/codehaus-plexus/plexus-archiver
+
+plexus-io (3.0.0)
+
+* License: Apache-2.0
+
+plexus-utils (3.1.0)
+
+* License: Apache- 2.0 or Apache- 1.1 or BSD or Public Domain or Indiana
+   University Extreme! Lab Software License V1.1.1 (Apache 1.1 style)
+
+relaxng-datatype (1.0)
+
+* License: New BSD license
+
+Sax (0.2)
+
+* License: SAX-PD
+* Project: http://www.megginson.com/downloads/SAX/
+* Source: http://sourceforge.net/project/showfiles.php?group_id=29449

Review Comment:
   Same as above — this was the JAXB RI's own upstream third-party list (Ant, testng, etc.), not jars we actually bundle. It's gone now that the glassfish JAXB runtime is excluded.



##########
amber/LICENSE-binary-java:
##########
@@ -690,9 +690,12 @@ Dependencies under the Eclipse Distribution License, Version 1.0
 
 Scala/Java jars:
   - com.sun.activation.jakarta.activation-2.0.0.jar
+  - com.sun.istack.istack-commons-runtime-3.0.12.jar

Review Comment:
   This was `jakarta.servlet.jsp-api` (EPL 2.0), also part of Hadoop's unused web stack — now excluded, so it's no longer bundled. (EPL 2.0 is ASF Category B, fine for binary distribution, so it would have been acceptable, but we don't need it here.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6227:
URL: https://github.com/apache/texera/pull/6227#discussion_r3540267901


##########
amber/build.sbt:
##########
@@ -158,7 +158,7 @@ val luceneDependencies = Seq(
 
 /////////////////////////////////////////////////////////////////////////////
 // Hadoop related
-val hadoopVersion = "3.4.3"
+val hadoopVersion = "3.5.0"

Review Comment:
   This bumps Hadoop only in `amber/build.sbt`, but `common/workflow-core/build.sbt` still declares `org.apache.hadoop % hadoop-common % "3.4.3"` (and `hadoop-mapreduce-client-core` at 3.4.3). Since `amber` depends on `WorkflowOperator` -> `WorkflowCore`, sbt will have to evict one version, which can lead to hard-to-debug runtime/linkage issues. Please keep Hadoop artifacts on a single version across modules (either bump WorkflowCore’s Hadoop deps to 3.5.0 too, or revert this change until the cross-module bump is done).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6227:
URL: https://github.com/apache/texera/pull/6227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #6227:
URL: https://github.com/apache/texera/pull/6227#discussion_r3555725147


##########
amber/build.sbt:
##########
@@ -158,16 +158,31 @@ val luceneDependencies = Seq(
 
 /////////////////////////////////////////////////////////////////////////////
 // Hadoop related
-val hadoopVersion = "3.4.3"
+val hadoopVersion = "3.5.0"
 val excludeHadoopJersey = ExclusionRule(organization = "com.sun.jersey")
 // Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
 // providers break Jersey 2 auto-discovery at startup, so exclude it as well.
 val excludeHadoopJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
+// Hadoop 3.5.0 moved its web stack to Jersey 2.x (org.glassfish.jersey.{core,containers,
+// inject}) plus the glassfish JAXB runtime, istack-commons, and the Jakarta JSP API. Left
+// in, Jersey 2.46 would evict Dropwizard 1.3.23's Jersey 2.25.1 (dropping the
+// AbstractValueFactoryProvider that dropwizard-auth needs). Texera uses hadoop only as a
+// filesystem client, so exclude the whole servlet/JAX-RS/JAXB web stack.

Review Comment:
   Reworded — but a clarification: this service (amber / WorkflowExecutionService) is actually still on Dropwizard 1.3.23 (`dropwizardVersion` a few lines up), which bundles Jersey 2.25.1. That's the whole reason the break is real here — Hadoop 3.5.0's Jersey 2.x evicts 2.25.1 and drops `AbstractValueFactoryProvider`. The 4.x / Jersey 3.x (jakarta) stack lives in the other services. I kept the version-specific detail since it's the actionable bit for future debugging, but scoped it explicitly to "this service" so it's clear it's not a repo-wide claim.



##########
common/workflow-core/build.sbt:
##########
@@ -160,7 +160,21 @@ val excludeJersey = ExclusionRule(organization = "com.sun.jersey")
 // Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
 // providers break Jersey 2 auto-discovery at startup, so exclude it as well.
 val excludeJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
-val excludeGlassfishJersey = ExclusionRule(organization = "org.glassfish.jersey")
+// Hadoop 3.5.0 moved its web stack from Jersey 1.x (com.sun.jersey) to Jersey 2.x
+// (org.glassfish.jersey.{core,containers,inject}) plus the glassfish JAXB runtime,
+// istack-commons, and the Jakarta JSP API. ExclusionRule matches the organization string
+// exactly, so a bare "org.glassfish.jersey" rule matches none of the real artifacts.
+// Texera uses hadoop only as a filesystem client, so none of this servlet/JAX-RS/JAXB
+// web stack is needed; excluding it keeps Dropwizard's Jersey 2.25.1 from being evicted
+// and keeps these jars out of every service dist.

Review Comment:
   Reworded here too. workflow-core is a plain library with no Dropwizard of its own, so I dropped the hardcoded versions and reframed it: the exclusion keeps the unused web-stack jars out of every downstream dist, and for the one downstream service still on a Jersey 2.x server (amber) it avoids evicting the Jersey its auth wiring needs. The org-string exactness note stays since that's version-independent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6227:
URL: https://github.com/apache/texera/pull/6227#issuecomment-4904378813

   <!-- texera-benchmarks-comment -->
   ## 📊 Arrow Flight E2E bench
   
   _(no arrow-flight-e2e.csv in artifact)_
   
   [Full dashboard](https://apache.github.io/texera/dev/bench/) · [Workflow run](https://github.com/apache/texera/actions/runs/28869165349)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #6227:
URL: https://github.com/apache/texera/pull/6227#issuecomment-4910126887

   Pushed a follow-up commit to get CI green — hadoop-common 3.5.0 swaps hadoop's web stack from Jersey 1.x (`com.sun.jersey`, which we already exclude) to Jersey 2.46 (`org.glassfish.jersey.*`). SBT's max-version eviction then bumped Dropwizard 1.3.23's Jersey 2.25.1 across the amber classpath, and 2.46 dropped `AbstractValueFactoryProvider` — which `dropwizard-auth` needs — so `ComputingUnitMaster` failed to compile.
   
   The 2.46 leaked in through three transitive paths (direct `hadoop-common`, `workflow-core`, and `commons-vfs2 -> hadoop-hdfs-client`), so instead of chasing per-edge exclusions I pinned the shared Jersey core/containers artifacts back to 2.25.1 in `WorkflowExecutionService` and dropped hadoop's 2.46-only `jersey-hk2` module. The resolved stack is now jersey 2.25.1 + hk2 2.5.0-b32, identical to `main`.
   
   Also synced `amber/LICENSE-binary-java` (hadoop 3.5.0 jars, dropped `jettison`, added the glassfish JAXB runtime hadoop now bundles) and regenerated `amber/NOTICE-binary`. Verified the amber compile, dist, and the PR-mode binary-license + NOTICE checks locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6227:
URL: https://github.com/apache/texera/pull/6227#issuecomment-4910142788

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6227?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 60.48%. Comparing base ([`40526b8`](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9e3545b`](https://app.codecov.io/gh/apache/texera/commit/9e3545b6ccb030429b43c5696b66df778f5158a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on main.
   :white_check_mark: All tests successful. No failed tests found.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #6227   +/-   ##
   =========================================
     Coverage     60.48%   60.48%           
     Complexity     3364     3364           
   =========================================
     Files          1133     1133           
     Lines         43979    43979           
     Branches       4781     4781           
   =========================================
     Hits          26599    26599           
     Misses        15924    15924           
     Partials       1456     1456           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.01% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.97% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.03% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.18% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [40526b8](https://app.codecov.io/gh/apache/texera/commit/40526b8e1783e7782ce6043e7ca72840b7fbe04d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6227?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6227:
URL: https://github.com/apache/texera/pull/6227#discussion_r3549974436


##########
common/workflow-core/build.sbt:
##########
@@ -160,7 +160,21 @@ val excludeJersey = ExclusionRule(organization = "com.sun.jersey")
 // Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
 // providers break Jersey 2 auto-discovery at startup, so exclude it as well.
 val excludeJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
-val excludeGlassfishJersey = ExclusionRule(organization = "org.glassfish.jersey")
+// Hadoop 3.5.0 moved its web stack from Jersey 1.x (com.sun.jersey) to Jersey 2.x
+// (org.glassfish.jersey.{core,containers,inject}) plus the glassfish JAXB runtime,
+// istack-commons, and the Jakarta JSP API. ExclusionRule matches the organization string
+// exactly, so a bare "org.glassfish.jersey" rule matches none of the real artifacts.
+// Texera uses hadoop only as a filesystem client, so none of this servlet/JAX-RS/JAXB
+// web stack is needed; excluding it keeps Dropwizard's Jersey 2.25.1 from being evicted
+// and keeps these jars out of every service dist.

Review Comment:
   The new comment references Dropwizard 1.3.23 / Jersey 2.25.1 eviction, but the repo is on Dropwizard 4.x (and Jersey 3.x is pinned elsewhere). Keeping outdated version-specific rationale here is misleading for future dependency work; it’s safer to describe the eviction risk without hardcoding old versions.



##########
amber/build.sbt:
##########
@@ -158,16 +158,31 @@ val luceneDependencies = Seq(
 
 /////////////////////////////////////////////////////////////////////////////
 // Hadoop related
-val hadoopVersion = "3.4.3"
+val hadoopVersion = "3.5.0"
 val excludeHadoopJersey = ExclusionRule(organization = "com.sun.jersey")
 // Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
 // providers break Jersey 2 auto-discovery at startup, so exclude it as well.
 val excludeHadoopJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
+// Hadoop 3.5.0 moved its web stack to Jersey 2.x (org.glassfish.jersey.{core,containers,
+// inject}) plus the glassfish JAXB runtime, istack-commons, and the Jakarta JSP API. Left
+// in, Jersey 2.46 would evict Dropwizard 1.3.23's Jersey 2.25.1 (dropping the
+// AbstractValueFactoryProvider that dropwizard-auth needs). Texera uses hadoop only as a
+// filesystem client, so exclude the whole servlet/JAX-RS/JAXB web stack.

Review Comment:
   This new comment hardcodes Dropwizard 1.3.23 and Jersey 2.25.1/2.46 as the motivation for the exclusions, but the repo is on Dropwizard 4.x (Jersey 3.x). The version-specific explanation is outdated and could confuse future dependency debugging; consider rewording to describe the eviction risk generically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(deps): bump org.apache.hadoop:hadoop-common from 3.4.3 to 3.5.0 [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #6227:
URL: https://github.com/apache/texera/pull/6227#discussion_r3549706667


##########
amber/LICENSE-binary-java:
##########
@@ -690,9 +690,12 @@ Dependencies under the Eclipse Distribution License, Version 1.0
 
 Scala/Java jars:
   - com.sun.activation.jakarta.activation-2.0.0.jar
+  - com.sun.istack.istack-commons-runtime-3.0.12.jar

Review Comment:
   I want to make sure this has a compatible license. presumably it is transitive from apache Hadoop, but good to check. 
   
   it has Eclipse Public License 2.0, is that good?



##########
amber/NOTICE-binary:
##########
@@ -503,6 +503,201 @@ which can be obtained from
 
   https://bitbucket.org/eunjeon/mecab-ko-dic/downloads/mecab-ko-dic-2.0.3-20170922.tar.gz
 
+--------------------------------------------------------------------------------
+com.sun.istack.istack-commons-runtime
+--------------------------------------------------------------------------------
+
+# Notices for Eclipse Implementation of JAXB
+
+This content is produced and maintained by the Eclipse Implementation of JAXB
+project.
+
+* Project home: https://projects.eclipse.org/projects/ee4j.jaxb-impl
+
+## Trademarks
+
+Eclipse Implementation of JAXB is a trademark of the Eclipse Foundation.
+
+## Copyright
+
+All content is the property of the respective authors or their employers. For
+more information regarding authorship of content, please consult the listed
+source code repository logs.
+
+## Declared Project Licenses
+
+This program and the accompanying materials are made available under the terms
+of the Eclipse Distribution License v. 1.0 which is available at
+http://www.eclipse.org/org/documents/edl-v10.php.
+
+SPDX-License-Identifier: BSD-3-Clause
+
+## Source Code
+
+The project maintains the following source code repositories:
+
+* https://github.com/eclipse-ee4j/jaxb-ri
+* https://github.com/eclipse-ee4j/jaxb-istack-commons
+* https://github.com/eclipse-ee4j/jaxb-dtd-parser
+* https://github.com/eclipse-ee4j/jaxb-fi
+* https://github.com/eclipse-ee4j/jaxb-stax-ex
+* https://github.com/eclipse-ee4j/jax-rpc-ri
+
+## Third-party Content
+
+This project leverages the following third party content.
+
+Apache Ant (1.10.2)
+
+* License: Apache-2.0 AND W3C AND LicenseRef-Public-Domain
+
+Apache Ant (1.10.2)
+
+* License: Apache-2.0 AND W3C AND LicenseRef-Public-Domain
+
+Apache Felix (1.2.0)
+
+* License: Apache License, 2.0
+
+args4j (2.33)
+
+* License: MIT License
+
+dom4j (1.6.1)
+
+* License: Custom license based on Apache 1.1
+
+file-management (3.0.0)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/shared/file-management/
+* Source:
+   https://svn.apache.org/viewvc/maven/shared/tags/file-management-3.0.0/
+
+JUnit (4.12)
+
+* License: Eclipse Public License
+
+JUnit (4.12)
+
+* License: Eclipse Public License
+
+maven-compat (3.5.2)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/ref/3.5.2/maven-compat/
+* Source:
+   https://mvnrepository.com/artifact/org.apache.maven/maven-compat/3.5.2
+
+maven-core (3.5.2)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/ref/3.5.2/maven-core/index.html
+* Source: https://mvnrepository.com/artifact/org.apache.maven/maven-core/3.5.2
+
+maven-plugin-annotations (3.5)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/plugin-tools/maven-plugin-annotations/
+* Source:
+   https://github.com/apache/maven-plugin-tools/tree/master/maven-plugin-annotations
+
+maven-plugin-api (3.5.2)
+
+* License: Apache-2.0
+
+maven-resolver-api (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-api (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-connector-basic (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-impl (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-spi (1.1.1)
+
+* License: Apache-2.0
+
+maven-resolver-transport-file (1.1.1)
+
+* License: Apache-2.0
+* Project: https://maven.apache.org/resolver/maven-resolver-transport-file/
+* Source:
+   https://github.com/apache/maven-resolver/tree/master/maven-resolver-transport-file
+
+maven-resolver-util (1.1.1)
+
+* License: Apache-2.0
+
+maven-settings (3.5.2)
+
+* License: Apache-2.0
+* Source:
+   https://mvnrepository.com/artifact/org.apache.maven/maven-settings/3.5.2
+
+OSGi Service Platform Core Companion Code (6.0)
+
+* License: Apache License, 2.0
+
+plexus-archiver (3.5)
+
+* License: Apache-2.0
+* Project: https://codehaus-plexus.github.io/plexus-archiver/
+* Source: https://github.com/codehaus-plexus/plexus-archiver
+
+plexus-io (3.0.0)
+
+* License: Apache-2.0
+
+plexus-utils (3.1.0)
+
+* License: Apache- 2.0 or Apache- 1.1 or BSD or Public Domain or Indiana
+   University Extreme! Lab Software License V1.1.1 (Apache 1.1 style)
+
+relaxng-datatype (1.0)
+
+* License: New BSD license
+
+Sax (0.2)
+
+* License: SAX-PD
+* Project: http://www.megginson.com/downloads/SAX/
+* Source: http://sourceforge.net/project/showfiles.php?group_id=29449

Review Comment:
   also this one



##########
amber/NOTICE-binary:
##########
@@ -503,6 +503,201 @@ which can be obtained from
 
   https://bitbucket.org/eunjeon/mecab-ko-dic/downloads/mecab-ko-dic-2.0.3-20170922.tar.gz
 
+--------------------------------------------------------------------------------
+com.sun.istack.istack-commons-runtime
+--------------------------------------------------------------------------------
+
+# Notices for Eclipse Implementation of JAXB
+
+This content is produced and maintained by the Eclipse Implementation of JAXB
+project.
+
+* Project home: https://projects.eclipse.org/projects/ee4j.jaxb-impl
+
+## Trademarks
+
+Eclipse Implementation of JAXB is a trademark of the Eclipse Foundation.
+
+## Copyright
+
+All content is the property of the respective authors or their employers. For
+more information regarding authorship of content, please consult the listed
+source code repository logs.
+
+## Declared Project Licenses
+
+This program and the accompanying materials are made available under the terms
+of the Eclipse Distribution License v. 1.0 which is available at
+http://www.eclipse.org/org/documents/edl-v10.php.
+
+SPDX-License-Identifier: BSD-3-Clause

Review Comment:
   is this license good to use?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org