You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/26 20:24:43 UTC
[GitHub] [airflow] dstandish opened a new pull request #22546: Deprecate connection extra prefix
dstandish opened a new pull request #22546:
URL: https://github.com/apache/airflow/pull/22546
Previously, connection "extra" fields which were added as custom fields in the
webserver connection form had to be named with prefix `extra__<conn_type>__`.
This was because custom fields are registered globally on the connection view model,
so the prefix was necessary to prevent collisions.
But the prefix is ugly and cumbersome in the `extra` field. So now what we do is
add this prefix when defining the field internally in the model, and strip it when
saving the connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #22546: Deprecate connection extra prefix
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #22546:
URL: https://github.com/apache/airflow/pull/22546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22546: Deprecate connection extra prefix
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #22546:
URL: https://github.com/apache/airflow/pull/22546#issuecomment-1080124539
> I like the idea. Not sure if I have all the skills to review :). But once the errors are fixed I can do some manual testing :)
jarek "lacking in skills" ... _right_ :)
i'm actually gonna close this and raise a different one that is much simpler / less invasive / not dependent on special "versioning" attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22546: Deprecate connection extra prefix
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22546:
URL: https://github.com/apache/airflow/pull/22546#issuecomment-1080013917
I like the idea. Not sure if I have all the skills to review :). But once the errors are fixed I can do some manual testing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org