You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/07/31 06:25:57 UTC

[GitHub] [spark] beliefer opened a new pull request, #42233: [SPARK-44340][SQL][PYTHON][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec

beliefer opened a new pull request, #42233:
URL: https://github.com/apache/spark/pull/42233

   ### What changes were proposed in this pull request?
   This is a followup of https://github.com/apache/spark/pull/41899, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup.
   
   
   ### Why are the changes needed?
   future-proof
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   ### How was this patch tested?
   existing tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #42233: [SPARK-44340][SQL][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42233:
URL: https://github.com/apache/spark/pull/42233#issuecomment-1658326513

   thanks, merging to 3.5!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #42233: [SPARK-44340][SQL][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42233:
URL: https://github.com/apache/spark/pull/42233#issuecomment-1659528794

   @cloud-fan Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #42233: [SPARK-44340][SQL][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #42233: [SPARK-44340][SQL][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec
URL: https://github.com/apache/spark/pull/42233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #42233: [SPARK-44340][SQL][FOLLOWUP][3.5] Set partition index correctly for WindowGroupLimitExec

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42233:
URL: https://github.com/apache/spark/pull/42233#issuecomment-1658324302

   @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org