You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/01 13:25:10 UTC

[GitHub] [pulsar] codelipenghui commented on pull request #17449: [fix][broker]Fix using schema to create consumer fails after using AUTO_CONSUME consumer to subscribe topic

codelipenghui commented on PR #17449:
URL: https://github.com/apache/pulsar/pull/17449#issuecomment-1298506639

   > The problem is not caused by the check of the AUTO_CONSUME.
   It is that there are some activeConsumer with AUTO_CONSUME.
   
   Oh, got it.
   
   > IMO, The check is confusing. If there is no hasSchema, then we should addSchema without other conditions.
   
   No, if we have active producers or consumers. The new schema might break the existing producer and consumers because they are using the byte[] schema in this case. The main reason is the client side will not upload the byte[] schema.
   
   I think the current fix will break the existing behavior (If there are active consumers with byte[] schema, the new schema should not be added to the schema registry)
   
   The client side will not upload the AUTO_CONSUME. That should be a challenge for us to know if all the active consumers are using the AUTO_CONSUME schema or byte[] schema.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org