[GitHub] [iceberg] nastra commented on pull request #6059: Core,Spark: Fix raw generics usage of ManifestWriter

[GitBox <gi...@apache.org>]

nastra commented on PR #6059:
URL: https://github.com/apache/iceberg/pull/6059#issuecomment-1300110052

   > @nastra would you mind providing some context regarding why it's there and why removed ?
   
   Not sure I fully understand your question. The problem is that with `ManifestWriter writer` you could technically end up in a situation where the `writer` gets a `DeleteFile` or any other type at runtime, which would break at **runtime**. Providing the generic type the `ManifestWriter` is writing will cause a **compile-time** issue, simply because a `ManifestWriter<DataFile> writer` can't  be supplied a `DeleteFile`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org