You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "timrobertson100 (GitHub)" <gi...@apache.org> on 2018/08/22 10:37:30 UTC
[GitHub] [beam] timrobertson100 opened pull request #6263:
[BEAM-5193] Correct typos in KuduIOTest testWrite
Corrects some typos which slipped in to the original Kudu commit in error and meant the kudu testWrite() was not doing what it was intended to do.
1) It has gone unnoticed presumably because test environments have had more than 3 processor cores. The intended design was to ensure only at least 3 which is the minimum parallelism that the DirectRunner will provide.
2) The second loop here was just a typo and never executed. This corrects that to verify behaviour.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] iemejia closed pull request #6263: [BEAM-5193]
Correct typos in KuduIOTest testWrite
Posted by "iemejia (GitHub)" <gi...@apache.org>.
[ pull request closed by iemejia ]
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] iemejia commented on issue #6263: [BEAM-5193] Correct
typos in KuduIOTest testWrite
Posted by "iemejia (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] timrobertson100 commented on issue #6263: [BEAM-5193]
Correct typos in KuduIOTest testWrite
Posted by "timrobertson100 (GitHub)" <gi...@apache.org>.
R: @iemejia
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] timrobertson100 commented on issue #6263: [BEAM-5193]
Correct typos in KuduIOTest testWrite
Posted by "timrobertson100 (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [beam] timrobertson100 commented on issue #6263: [BEAM-5193]
Correct typos in KuduIOTest testWrite
Posted by "timrobertson100 (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/beam/pull/6263 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org