[jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

["Lothar Haeger (JIRA)" <ji...@apache.org>]

Lothar Haeger created DIRSTUDIO-1156:
----------------------------------------

             Summary: Text Editor usability improvements
                 Key: DIRSTUDIO-1156
                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1156
             Project: Directory Studio
          Issue Type: Improvement
          Components: studio-ldapbrowser
    Affects Versions: 2.0.0-M13
         Environment: Windows
            Reporter: Lothar Haeger
            Priority: Minor


As an IDM developer I work a lot with XML blobs stored in binary attributes. Those values open in Hex Editor initially, which has a "Edit as Text..." button to open the value in a Text Editor if possible (i.e. not containing any non-printable characters). There are a few aspects to improve here, especially when working with long lines of text or overall large texts:

* the Text Editor cannot be maximized on all platforms. SWT.RESIZE is set, but is a lot less convenient to use if you need as much screen area as possible. Possible solution: add SWT.MAX when creating the dialog
* the Text Editor does not support line wrapping. XML or JSON data is often stored without line breaks, which requires cumbersome horizontal scrolling. Possible solution: add a "wrap lines" check box (display only, not adding line breaks to the value text, inactive by default)
* the Text Editor dialog has a relatively small default size, a  ~50% wider/higher seems reasonable
* the button to open the Text Editor from Hex Editor is always displayed, even if the binary value is not editable (e.g. contains an image). Only when the button has been pressed a check is performed and an error message shown. It would be more intuitive to hide the button if a binary value cannot be edited as text in the first place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

[Emmanuel Lécharny <el...@gmail.com>]

Le 10/10/2017 à 15:01, Lothar Haeger a écrit :
> Emmanuel Lécharny wrote:
>
>> Was it the question ?
> That was just the first question! :-)
>
> next up: what's the preferred way to contribute code changes? Attach a
> diff/patch to the JIRA ticket? Fork Studio (from github.com or
> gitbox.apache.org, when it'smigrated) and send a pull request?

Whatever you prefer :-)


You won't be able to commit in trunk (yet), we need to vote you as a
committer first.

-- 
Emmanuel Lecharny

Symas.com
directory.apache.org

Re: [jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

[Lothar Haeger <lo...@brummelhook.com>]

Emmanuel Lécharny wrote:

> Was it the question ?

That was just the first question! :-)

next up: what's the preferred way to contribute code changes? Attach a
diff/patch to the JIRA ticket? Fork Studio (from github.com or
gitbox.apache.org, when it'smigrated) and send a pull request? Create a branch
and ask (whom?) for to merge it into trunk? Commit to trunk directly?

Re: [jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

[Emmanuel Lécharny <el...@gmail.com>]

Hi Lothar,


Le 10/10/2017 à 13:28, Lothar Haeger a écrit :
> So I've created this JIRA entry, because that stuff annoys me almost every day
> (a very little), is easy to fix and let's me explore how to contributing to
> Studio would work in practice.
:-)
>
> First challenge: how become assignee for this topic in JIRA? 

I just assigned you to the ticket.

> Who can enable my
> account for development work and what is the process to get it done?

If you are just talking about JIRA, I added you to the 'contributors'
group, that allows me to assign you to the ticket.


Was it the question ?

Thanks !

-- 
Emmanuel Lecharny

Symas.com
directory.apache.org

Re: [jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

[Stefan Seelmann <ma...@stefan-seelmann.de>]

On 10/10/2017 01:28 PM, Lothar Haeger wrote:
> So I've created this JIRA entry, because that stuff annoys me almost every day
> (a very little), is easy to fix and let's me explore how to contributing to
> Studio would work in practice.

Very great, fixing one's own problems motivates most. Happy contributing :)

Re: [jira] [Created] (DIRSTUDIO-1156) Text Editor usability improvements

[Lothar Haeger <lo...@brummelhook.com>]

So I've created this JIRA entry, because that stuff annoys me almost every day
(a very little), is easy to fix and let's me explore how to contributing to
Studio would work in practice.

First challenge: how become assignee for this topic in JIRA? Who can enable my
account for development work and what is the process to get it done?