You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/05/06 23:27:48 UTC
[GitHub] [jmeter] rollno748 opened a new pull request, #710: Added Shortcut key event for Reset search - 66053
rollno748 opened a new pull request, #710:
URL: https://github.com/apache/jmeter/pull/710
## Description
Shortcut key to Reset Search
## Motivation and Context
This shortcut will help to Reset Search while enhancing or debugging the script
## How Has This Been Tested?
Executed Unit test on core
Validated the shortcut in local - works perfectly!
## Screenshots (if appropriate):
## Types of changes
* Adding Keyevent to enable shortcut for reset search functionality (non-breaking change which uses existing functionality)
## Checklist:
- [ ] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] pmouawad commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
pmouawad commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121507626
Hello @rollno748 ,
Thanks for contributing.
Can you run ./gradlew autostyleApply and commit the result please ?
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
rollno748 commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121550885
Yes the current shortcut is assigned to ctrl+alt+f to reset the search.
I haven't considered the esc to set it as reset search.
I thought, It would be easier for us to remember to go with the same keys used to search (ctrl + f) - with an alternate key added for reset
Happy to hear your thoughts as well
please advise !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
rollno748 commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1120185917
@vlsi - can you please review and approve
Its just a minor change in adding shortcut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
vlsi commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1122159237
Frankly speaking, I think we should try using `ESC` shortcut for "resetting the search"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
rollno748 commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121514349
Thanks for reviewing it @pmouawad
I have applied the autostyle and committed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
vlsi commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121541948
Am I right the suggested shortcut is `ctrl+alt+f` to reset the search?
Does it come from a standard?
Have you considered using `esc` shortcut to reset the search?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi merged pull request #710: Added Shortcut key event for Reset search - 66053
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi merged PR #710:
URL: https://github.com/apache/jmeter/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-commenter commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1120077529
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#710](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (437be96) into [master](https://codecov.io/gh/apache/jmeter/commit/4f05afcdd617bd89fb38b608db3196e29ab19e87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f05afc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #710 +/- ##
============================================
- Coverage 55.24% 55.23% -0.02%
+ Complexity 10385 10381 -4
============================================
Files 1061 1061
Lines 65762 65763 +1
Branches 7531 7531
============================================
- Hits 36333 36321 -12
- Misses 26830 26842 +12
- Partials 2599 2600 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/jmeter/gui/action/KeyStrokes.java](https://codecov.io/gh/apache/jmeter/pull/710/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvYWN0aW9uL0tleVN0cm9rZXMuamF2YQ==) | `91.80% <100.00%> (+0.13%)` | :arrow_up: |
| [...java/org/apache/jmeter/gui/util/JMeterMenuBar.java](https://codecov.io/gh/apache/jmeter/pull/710/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvdXRpbC9KTWV0ZXJNZW51QmFyLmphdmE=) | `78.25% <100.00%> (ø)` | |
| [.../jmeter/protocol/http/sampler/HTTPSamplerBase.java](https://codecov.io/gh/apache/jmeter/pull/710/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3NhbXBsZXIvSFRUUFNhbXBsZXJCYXNlLmphdmE=) | `70.50% <0.00%> (-1.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4f05afc...437be96](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by GitBox <gi...@apache.org>.
rollno748 commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1122210750
Cool, Thanks for the inputs.
I will make that change and commit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #710:
URL: https://github.com/apache/jmeter/pull/710#issuecomment-1554612554
@rollno748 , thanks. For the next PR, please create a different branch. It is not a good idea to create PRs from `master` branch. For instance, in that case you won't be able to create two PRs at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org