[GitHub] [zeppelin] zjffdu opened a new pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

[GitBox <gi...@apache.org>]

zjffdu opened a new pull request #4336:
URL: https://github.com/apache/zeppelin/pull/4336


   ### What is this PR for?
   
   Trim the space for the key & value of ConfInterpreter. Unit test is added.
   
   ### What type of PR is it?
   [Bug Fix ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5669
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4336:
URL: https://github.com/apache/zeppelin/pull/4336#discussion_r838684505



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java
##########
@@ -67,6 +67,9 @@ public InterpreterResult interpret(String st, InterpreterContext context)
       finalProperties.putAll(getProperties());
       Properties newProperties = new Properties();
       newProperties.load(new StringReader(st));
+      for (String key : newProperties.stringPropertyNames()) {

Review comment:
       Is it intentional that now the keys with and without trim are included in the list?
   If so, then a test should cover this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org