You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Micha Lenk <mi...@lenk.info> on 2011/09/09 11:30:12 UTC

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

Hi Rüdiger,

On 08/23/2011 12:25 PM CEST +02:00, "Plüm, Rüdiger, VF-Group" wrote:
> IMHO the patch does not solve the issue mentioned in the comment
> and is not needed.
> Keep in mind the difference between ap_matches_request_vhost and
> check_host_alias:
> 
> ap_matches_request_vhost checks only the data of *one* server_rec
> and hence only *one* Servername and ServerAlias settings as set for
> this vhost, whereas check_host_alias scans over *multiple* server_recs
> with *multiple* Servername and ServerAlias settings from different vhosts.

Okay, good point. Then the first patch should indeed be sufficient.

What is needed to get it applied to trunk?

Regards,
Micha

Re: [PATCH 51709] With IP address in Host: header ServerName/ServerAlias doesn't work

Posted by Micha Lenk <mi...@lenk.info>.

Hi,

Am 09.09.2011 11:45, schrieb "Plüm, Rüdiger, VF-Group":
> 2. Update the needed patch to be against trunk.

Once again with attached patch for issue 51709, ready for review. Please
review it and consider it for commit.

Thanks,
Micha

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

Posted by Micha Lenk <mi...@lenk.info>.

Hi Rüdiger,

Am 09.09.2011 11:45, schrieb "Plüm, Rüdiger, VF-Group":
> Please update the bug report:
> 
> 1. Declare the unneeded patch obsolete.
> 2. Update the needed patch to be against trunk.

Done. See https://issues.apache.org/bugzilla/show_bug.cgi?id=51709
What else is needed to get it applied to trunk?

Regards,
Micha

RE: With IP address in Host: header ServerName/ServerAlias doesn't work

Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.

Please update the bug report:

1. Declare the unneeded patch obsolete.
2. Update the needed patch to be against trunk.

Regards

Rüdiger 

> -----Original Message-----
> From: Micha Lenk 
> Sent: Freitag, 9. September 2011 11:30
> To: dev@httpd.apache.org
> Subject: Re: With IP address in Host: header 
> ServerName/ServerAlias doesn't work
> 
> Hi Rüdiger,
> 
> On 08/23/2011 12:25 PM CEST +02:00, "Plüm, Rüdiger, VF-Group" wrote:
> > IMHO the patch does not solve the issue mentioned in the comment
> > and is not needed.
> > Keep in mind the difference between ap_matches_request_vhost and
> > check_host_alias:
> > 
> > ap_matches_request_vhost checks only the data of *one* server_rec
> > and hence only *one* Servername and ServerAlias settings as set for
> > this vhost, whereas check_host_alias scans over *multiple* 
> server_recs
> > with *multiple* Servername and ServerAlias settings from 
> different vhosts.
> 
> Okay, good point. Then the first patch should indeed be sufficient.
> 
> What is needed to get it applied to trunk?
> 
> Regards,
> Micha
>