You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/09 18:39:31 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
xiaoxiang781216 opened a new pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357
follow up the kernel side change
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#issuecomment-672073297
Yes, I will open an issue track this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#issuecomment-672074197
Just see you already opened an issue for this: https://github.com/apache/incubator-nuttx-apps/issues/360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo merged pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636359
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
/* Set up a timer to prevent hangs */
- ret = wd_start(session->wdog,
- session->conntimeo, ftpc_timeout, 1, session);
+ ret = wd_start(&session->wdog, session->conntimeo,
Review comment:
Hmm.. this is another violation of the portable POSIX OS interface. wd_start(0 is not an application accessible interface. It is only for use inside the OS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468637397
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
/* Set up a timer to prevent hangs */
- ret = wd_start(session->wdog,
- session->conntimeo, ftpc_timeout, 1, session);
+ ret = wd_start(&session->wdog, session->conntimeo,
Review comment:
This function cannot be called in PROTECTED or KERNEL build modes nor can they do the interrupt handling logic access user space. Remember that the callback is in the context of the timer interrupt handler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636769
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -214,7 +210,7 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
fptc_getreply(session);
}
- wd_cancel(session->wdog);
+ wd_cancel(&session->wdog);
Review comment:
Not a legal OS interface. See wd_start() comments above.
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
/* Set up a timer to prevent hangs */
- ret = wd_start(session->wdog,
- session->conntimeo, ftpc_timeout, 1, session);
+ ret = wd_start(&session->wdog, session->conntimeo,
Review comment:
This function cannot be called in PROTECTED or KERNEL build modes not can the interrupt handling logic access user space. Remember that the callback is in the context of the timer interrupt handler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org