You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/19 10:58:39 UTC

[GitHub] [spark] gaborgsomogyi commented on pull request #30076: [SPARK-32862][SS] Left semi stream-stream join

gaborgsomogyi commented on pull request #30076:
URL: https://github.com/apache/spark/pull/30076#issuecomment-712050432


   I've just picked this up and from high level perspective I see at least 2 things in the PR:
   * Test code deduplication (which is good to do)
   * Left semi join itself
   
   I suggest to split them up by creating a jira for the test code deduplication.
   That would make the PR more consize and easier to review.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org