You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hiSandog (via GitHub)" <gi...@apache.org> on 2026/05/30 03:12:49 UTC
[PR] [fix][client] Handle synchronous RetryUtil supplier failures [pulsar]
hiSandog opened a new pull request, #25893:
URL: https://github.com/apache/pulsar/pull/25893
### Motivation
RetryUtil retries when the returned future completes exceptionally, but a supplier that throws before returning a future escapes the retry path and can leave the callback incomplete.
### Modifications
Route synchronous supplier failures through the same retry and mandatory-stop handling used for failed futures, and add a focused regression test.
### Verifying this change
- git diff --check
- ./gradlew :pulsar-broker:test --tests org.apache.pulsar.client.impl.RetryUtilTest (could not run locally: no Java runtime is installed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Handle synchronous RetryUtil supplier failures [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25893:
URL: https://github.com/apache/pulsar/pull/25893#issuecomment-4624471545
removing RetryUtil in #25934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Handle synchronous RetryUtil supplier failures [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #25893: [fix][client] Handle synchronous RetryUtil supplier failures
URL: https://github.com/apache/pulsar/pull/25893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Handle synchronous RetryUtil supplier failures [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25893:
URL: https://github.com/apache/pulsar/pull/25893#issuecomment-4616215336
> * (could not run locally: no Java runtime is installed)
@hiSandog have you personally reviewed this PR? This is a useful improvement. Our policy is that real humans must validate PRs before submitting. Please read https://github.com/apache/pulsar/blob/master/AGENTS.md#licensing-and-provenance-read-first for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Handle synchronous RetryUtil supplier failures [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25893:
URL: https://github.com/apache/pulsar/pull/25893#issuecomment-4624442222
RetryUtil isn't used in any production code of maintained Pulsar branches (branch-4.0, branch-4.2 or master). Let's remove the class instead. If there's a need to add a similar solution, it can be done later. For example adding a `asyncRetry` method to `FutureUtil` in `pulsar-common`. Since we don't currently have the use case, it's better to postpone adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org