[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7109: Flink: Apply row level filtering

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #7109:
URL: https://github.com/apache/iceberg/pull/7109#discussion_r1284732661


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java:
##########
@@ -120,6 +138,9 @@ private CloseableIterable<RowData> newIterable(
       }
     }
 
+    if (rowFilter != null) {
+      return CloseableIterable.filter(iter, rowFilter::filter);
+    }

Review Comment:
   >  I believe maybe we don't have to passing the filters all the way done to this class.. The task itself already has the row filter task.residual(). 
   
   if that is the case, it is probably simpler.
   
   > add row filter dynamically,
   
   can you explain what's the dynamic part and how is it related to the residual filter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org