[GitHub] [airflow] thesuperzapper commented on a change in pull request #12009: Fix chart network policies definion and compliance

[GitBox <gi...@apache.org>]

thesuperzapper commented on a change in pull request #12009:
URL: https://github.com/apache/airflow/pull/12009#discussion_r520963745



##########
File path: chart/templates/webserver/webserver-networkpolicy.yaml
##########
@@ -39,13 +39,13 @@ spec:
       component: webserver
       release: {{ .Release.Name }}
   policyTypes:
-  - Ingress
-  ingress:
-  - from:
+    - Ingress
 {{- if .Values.webserver.extraNetworkPolicies }}
-{{ toYaml .Values.webserver.extraNetworkPolicies | indent 4 }}
+  ingress:
+    - from:
+{{ toYaml .Values.webserver.extraNetworkPolicies | indent 6 }}

Review comment:
       @mik-laj I don't know what the creator of this specific PR was trying to achieve, but from context, its just a way for users to specify things under `from` using a list value, for example:
   ```yaml
   webserver:
     extraNetworkPolicies:
       - ipBlock:
           cidr: 172.17.0.0/16
           except:
             - 172.17.1.0/24
       - namespaceSelector:
           matchLabels:
             project: myproject
       - podSelector:
           matchLabels:
             role: frontend
   ```
   
   You can read about NetworkPolicy here: https://kubernetes.io/docs/concepts/services-networking/network-policies/
   
   But this is just another case where there needs to be significant documentation updates for this chart before it's ready for normal users.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org