You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/01 16:38:52 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #288: Run javafmt check all
mdedetrich opened a new pull request, #288:
URL: https://github.com/apache/incubator-pekko-http/pull/288
The CI check for java code ended up not checking that test sources were formatted so this PR fixes. Make sure to let me rebase and merge because I need to add the commit to `.git-ignore-blame-revs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #288: Run javafmt check all
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #288:
URL: https://github.com/apache/incubator-pekko-http/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #288: Run javafmt check all
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #288:
URL: https://github.com/apache/incubator-pekko-http/pull/288#discussion_r1280897480
##########
.github/workflows/validate-and-test.yml:
##########
@@ -36,7 +36,7 @@ jobs:
key: build-target-${{ hashFiles('**/*.sbt', 'project/build.properties', 'project/**/*.scala') }}
- name: Check code is formatted
- run: sbt javafmtCheck
Review Comment:
The original `javafmtCheck` didn't check if Java test sources were formatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org