You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/05/30 06:09:00 UTC
[PR] fix(security): guard dynamic dispatch and bound a regex quantifier [superset]
rusackas opened a new pull request, #40547:
URL: https://github.com/apache/superset/pull/40547
### SUMMARY
Resolves the remaining two high-severity CodeQL findings:
- **Dynamic dispatch (`asyncEvent.ts`):** the async-event middleware looked up a listener by a server-supplied job id and invoked it. Now the dynamic property access is guarded with an own-property check, so the lookup can only resolve to a listener the app actually registered (not an inherited object method).
- **Regex backtracking (`boxplotOperator.ts`):** the boxplot percentile pattern used unbounded digit quantifiers. Since these values are always in the 0–100 range, the quantifiers are now bounded, removing the backtracking risk while preserving matching behavior.
Both are minimal, behavior-preserving changes.
### TESTING INSTRUCTIONS
- [ ] CI passes (frontend lint / type-check / unit tests)
- [ ] Boxplot "X/Y percentiles" whisker option still parses correctly
- [ ] Async event listeners still fire for registered job ids
- [ ] The relevant CodeQL alerts no longer appear after the next scan
### ADDITIONAL INFORMATION
- [ ] Has associated issue: addresses code-scanning alerts
- [ ] Required feature flags: n/a
- [ ] Changes UI: No
- [ ] Includes DB Migration: No
- [ ] Introduces new feature or API: No
- [ ] Removes existing feature or API: No
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): guard dynamic dispatch and bound a regex quantifier [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40547:
URL: https://github.com/apache/superset/pull/40547#issuecomment-4581937534
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40547?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.99%. Comparing base ([`838ee27`](https://app.codecov.io/gh/apache/superset/commit/838ee27c2995140ea620d2e109ede828556ac050?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2824fec`](https://app.codecov.io/gh/apache/superset/commit/2824fecf75bd1a9ca2e45b3e9d7ec09cc5bc914c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40547 +/- ##
=======================================
Coverage 63.99% 63.99%
=======================================
Files 2637 2637
Lines 141679 141681 +2
Branches 32570 32572 +2
=======================================
+ Hits 90671 90674 +3
+ Misses 49452 49451 -1
Partials 1556 1556
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40547/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.34% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40547?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): guard dynamic dispatch and bound a regex quantifier [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40547:
URL: https://github.com/apache/superset/pull/40547#issuecomment-4581923014
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2824fecf75bd1a9ca2e45b3e9d7ec09cc5bc914c |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a1a7efd0c6f0b0008975fd2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40547--superset-docs-preview.netlify.app](https://deploy-preview-40547--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpJDoAgDADAv_QssZqIyw98Rm0hmLAFPUiMf5fbHOaFXFLIN2wAHRyFIrtmez691EjhZBXM7ZIoJu8VRVHFSLpaFpN9qru0rmmg2VhB1hYPRFzWebIywvcD) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40547--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): guard dynamic dispatch and bound a regex quantifier [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40547:
URL: https://github.com/apache/superset/pull/40547#issuecomment-4581918802
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(security): guard dynamic dispatch and bound a regex quantifier [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40547:
URL: https://github.com/apache/superset/pull/40547#issuecomment-4581919129
Congrats on making your first PR and thank you for contributing to Superset! :tada: :heart:
Please read our [New Contributor Welcome & Expectations](https://github.com/apache/superset/wiki/New-Contributor-Welcome-&-Expectations) guide.
We hope to see you in our [Slack](https://apache-superset.slack.com/) community too! Not signed up? Use our [Slack App](http://bit.ly/join-superset-slack) to self-register.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: guard dynamic dispatch and bound a regex quantifier [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40547:
URL: https://github.com/apache/superset/pull/40547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org