[jira] [Commented] (JAMES-1605) AbstractRecipientRewriteTable.mapAddress doesn't respect domainAlias ordering

["ASF GitHub Bot (JIRA)" <se...@james.apache.org>]

    [ https://issues.apache.org/jira/browse/JAMES-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964815#comment-14964815 ] 

ASF GitHub Bot commented on JAMES-1605:
---------------------------------------

Github user mbaechler closed the pull request at:

    https://github.com/apache/james/pull/3


> AbstractRecipientRewriteTable.mapAddress doesn't respect domainAlias ordering
> -----------------------------------------------------------------------------
>
>                 Key: JAMES-1605
>                 URL: https://issues.apache.org/jira/browse/JAMES-1605
>             Project: James Server
>          Issue Type: Bug
>            Reporter: Matthieu Baechler
>
> This code snippet seems to tries to putting aliasdomain entries in front of the list while keeping entries original order.
>  
> {code}
>  while (mapIt.hasNext()) {
>                 int i = 0;
>                 String mapping = mapIt.next();
>                 if (mapping.startsWith(RecipientRewriteTable.ALIASDOMAIN_PREFIX)) {
>                     col.add(i, mapping);
>                     i++;
>                 } else {
>                     col.add(mapping);
>                 }
>             }
> {code}
> I looks like no test covers this feature because it actually mess with aliasdomain ordering (the 'i' counter is reset for every loop)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org