You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/26 08:09:05 UTC

[GitHub] [skywalking] codecov-io edited a comment on issue #4418: refactor Metrics class.

codecov-io edited a comment on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591279244
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=h1) Report
   > Merging [#4418](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fa0b3df3692d5e60d072a2dec4fb6c0a9eafc8b5?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4418/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4418      +/-   ##
   ==========================================
   + Coverage   25.42%   25.45%   +0.03%     
   ==========================================
     Files        1211     1211              
     Lines       28082    28082              
     Branches     3869     3866       -3     
   ==========================================
   + Hits         7139     7149      +10     
   + Misses      20292    20282      -10     
     Partials      651      651
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `55.17% <100%> (+10.34%)` | :arrow_up: |
   | [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=footer). Last update [fa0b3df...5f6915b](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services