You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2022/05/20 15:05:53 UTC
[pulsar] 11/31: [Proxy] Remove unnecessary blocking DNS lookup in LookupProxyHandler (#15415)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit d776e17dcaff01afcefee42c83e35e35cc624b2a
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Tue May 3 22:49:43 2022 +0300
[Proxy] Remove unnecessary blocking DNS lookup in LookupProxyHandler (#15415)
* [Proxy] Remove unnecessary blocking DNS lookup in LookupProxyHandler
* Use existing code pattern for creating address
(cherry picked from commit 7373a51690d728475d47846bfbcca4fa64f2e228)
---
.../pulsar/proxy/server/LookupProxyHandler.java | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
index 69d60fcabd0..c242242d0c9 100644
--- a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
+++ b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
@@ -215,20 +215,16 @@ public class LookupProxyHandler {
private void handlePartitionMetadataResponse(CommandPartitionedTopicMetadata partitionMetadata,
long clientRequestId) {
TopicName topicName = TopicName.get(partitionMetadata.getTopic());
- URI brokerURI;
- try {
- String availableBrokerServiceURL = getBrokerServiceUrl(clientRequestId);
- if (availableBrokerServiceURL == null) {
- log.warn("No available broker for {} to lookup partition metadata", topicName);
- return;
- }
- brokerURI = new URI(availableBrokerServiceURL);
- } catch (URISyntaxException e) {
- proxyConnection.ctx().writeAndFlush(Commands.newPartitionMetadataResponse(ServerError.MetadataError,
- e.getMessage(), clientRequestId));
+
+ String serviceUrl = getBrokerServiceUrl(clientRequestId);
+ if (serviceUrl == null) {
+ log.warn("No available broker for {} to lookup partition metadata", topicName);
+ return;
+ }
+ InetSocketAddress addr = getAddr(serviceUrl, clientRequestId);
+ if (addr == null) {
return;
}
- InetSocketAddress addr = new InetSocketAddress(brokerURI.getHost(), brokerURI.getPort());
if (log.isDebugEnabled()) {
log.debug("Getting connections to '{}' for Looking up topic '{}' with clientReq Id '{}'", addr,