You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/06 15:37:48 UTC
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 opened a new pull request, #10: Add property API
lujiajing1126 opened a new pull request, #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10
The last piece of BanyanDB Client.
Close https://github.com/apache/skywalking/issues/8502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851614415
##########
src/test/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClientTestCI.java:
##########
@@ -30,21 +30,21 @@
public class BanyanDBClientTestCI {
private static final String REGISTRY = "ghcr.io";
private static final String IMAGE_NAME = "apache/skywalking-banyandb";
- private static final String TAG = "6f081f2f8e1f59a762513175b9cb69964bb43d07";
+ private static final String TAG = "ad94bb9e39276a985d1647cacae4afc565b17d83";
Review Comment:
@wu-sheng It is changed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851240383
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ if (ex.getStatus().equals(Status.Code.NOT_FOUND)) {
Review Comment:
The relevant querying APIs have a chance to follow this convention. I will fill an issue to track this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851589217
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
OK, please fix CI, and once issue filed, I am good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851236363
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ if (ex.getStatus().equals(Status.Code.NOT_FOUND)) {
Review Comment:
Is other API adopting status code later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1090974250
> BTW, we have to refactor `StatusCode` returned from the BanyanBD @hanahmily
Could you file an issue to elaborate on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851239819
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
Review Comment:
I don't think so. He might miss it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r844551948
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,31 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ // TODO: polish "404" response code in BanyanDB
Review Comment:
Do you tend to have the server return 404 on missing properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1100634814
I mean, I don't see the banyandb server version change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r844562789
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,31 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ // TODO: polish "404" response code in BanyanDB
Review Comment:
Yes. I think so. Currently, it is `UNKNOWN`. It is not easy to distinguish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851590383
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
> OK, please fix CI, and once issue filed, I am good.
CI failure is caused by the Banyandb side. I am checking this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851236244
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
Review Comment:
I think you miss `delete`, is this on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851613046
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
> OK, please fix CI, and once issue filed, I am good.
Everything is fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851728800
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ if (ex.getStatus().equals(Status.Code.NOT_FOUND)) {
Review Comment:
https://github.com/apache/skywalking/issues/8888 created, as no one created in 2 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r844562789
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,31 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ // TODO: polish "404" response code in BanyanDB
Review Comment:
Yes. I mean `Code.NOT_FOUND`. Currently, it is `UNKNOWN`. It is not easy to distinguish.
https://jbrandhorst.com/post/grpc-errors/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r844575059
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,31 @@ public void define(Measure measure) throws BanyanDBException {
MetadataCache.INSTANCE.register(measure);
}
+ /**
+ * Create or update the property
+ *
+ * @param property the property to be stored in the BanyanBD
+ */
+ public void save(Property property) throws BanyanDBException {
+ PropertyStore store = new PropertyStore(checkNotNull(this.channel));
+ try {
+ store.get(property.group(), property.name(), property.id());
+ store.update(property);
+ } catch (BanyanDBException ex) {
+ // TODO: polish "404" response code in BanyanDB
Review Comment:
https://github.com/apache/skywalking/issues/8829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851572634
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
We could improve the property API in the next round. If it makes sense to us, I will fill an issue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1100632249
So, it is not a server bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1100632444
> So, it is not a server bug?
It is a bug and it has been fixed in https://github.com/apache/skywalking-banyandb/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851338677
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
If so, do these dashboards have to keep in memory, and filter based on query conditions in memory? Then in OAP cluster mode, the memory could be un-sync from time to time when users update from the web.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851337286
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
Could a tag be as a condition? The example shown here makes me feel, you are going to use one key to store all dashboards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng merged pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1090933917
You forgot to update the readme.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] github-actions[bot] commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r844100110
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/PropertyStore.java:
##########
@@ -0,0 +1,76 @@
+package org.apache.skywalking.banyandb.v1.client.metadata;
Review Comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
*/
package org.apache.skywalking.banyandb.v1.client.metadata;
```
<!-- license-eye hidden identification -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1091008889
> > BTW, we have to refactor `StatusCode` returned from the BanyanBD @hanahmily
>
> Could you file an issue to elaborate on this?
I also filed an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851341995
##########
README.md:
##########
@@ -225,6 +225,38 @@ MeasureWrite measureWrite = new MeasureWrite("sw_metric", "service_cpm_minute",
measureBulkWriteProcessor.add(measureWrite);
```
+## Property APIs
Review Comment:
<img width="78" alt="image" src="https://user-images.githubusercontent.com/5441976/163591336-c49aa4ff-f846-43d7-bf98-3b818e93c4fb.png">
These are dashboard configurations of one layer(general), and all dashboards mean all layers. You may face 35k-150k per layer, and 10+ layers right now(will add more in the future).
If the OAP Banyandb storage implementation has to load all of them to do one query, it will be an issue.
`ui-template` as property name/ID, and layer should be a tag key, we should support reading and updating one key's value per time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on pull request #10: Add property API
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#issuecomment-1100052139
Ready for review @hanahmily @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org