You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/12 08:59:47 UTC

[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #4727: fix statement containning columnsegment

jingshanglu opened a new pull request #4727: fix statement containning columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727
 
 
   Fixes #4671.
   
   Changes proposed in this pull request:
   - Instead of columnName, parse ColumnSegment as  member of RenameColumnSegment
   - Instead of columnName, parse ColumnSegment as  member of ColumnAfterPositionSegment
   - Instead of columnName, parse ColumnSegment as  member of ColumnPositionSegment
   - Instead of columnName, parse ColumnSegment as  member of ColumnDefinitionSegment
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#issuecomment-598096699
 
 
   ## Pull Request Test Coverage Report for [Build 10198](https://coveralls.io/builds/29297990)
   
   * **0** of **14**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **93** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.01%**) to **59.079%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/impl/SQL92DDLVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2Fimpl%2FSQL92DDLVisitor.java#L94) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/impl/OracleDDLVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2Fimpl%2FOracleDDLVisitor.java#L112) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDDLVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2Fimpl%2FSQLServerDDLVisitor.java#L108) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/ColumnDefinitionSegment.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fddl%2Fcolumn%2FColumnDefinitionSegment.java#L47) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L168) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/impl/MySQLDDLVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2Fimpl%2FMySQLDDLVisitor.java#L231) | 0 | 4 | 0.0%
   <!-- | **Total:** | **0** | **14** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29297990/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java](https://coveralls.io/builds/29297990/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2FOracleVisitor.java#L107) | 90 | 0% |
   <!-- | **Total:** | **93** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29297990/badge)](https://coveralls.io/builds/29297990) |
   | :-- | --: |
   | Change from base [Build 1054](https://coveralls.io/builds/29296741): |  -0.01% |
   | Covered Lines: | 12185 |
   | Relevant Lines: | 20625 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r391978134
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   ColumnPositionSegment include columnName, and the type of columnName is ColumnSegment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r391978237
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   the same as above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r392001938
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   ColumnPositionSegment include columnName, the type od columnName is ColumnSegment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r391520641
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   Why do not you change it as `columnSegment`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r391978134
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   ColumnPositionSegment include columnName, and the type of columnName is ColumnSegment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4727: fix statement containing columnsegment

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #4727: fix statement containing columnsegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4727#discussion_r391519320
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/ddl/column/position/ColumnAfterPositionSegment.java
 ##########
 @@ -27,7 +28,7 @@
     
     private final String afterColumnName;
 
 Review comment:
   Why do not change it as ColumnSegment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services