You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "akashorabek (via GitHub)" <gi...@apache.org> on 2025/03/07 14:56:53 UTC

[PR] Skip some tests on Dataflow runners [beam]

akashorabek opened a new pull request, #34209:
URL: https://github.com/apache/beam/pull/34209

   
   Fixes: [#30729](https://github.com/apache/beam/issues/30729)
   Successful run example: https://github.com/akashorabek/beam/actions/runs/13722098733
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1986112419


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,11 +619,9 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
-    if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
-    }
+    // Skipping dynamic destinations tests on Dataflow because of timing issues.
+    // These tests are more stable on the DirectRunner, where timing is less variable.
+    assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"));

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #34209:
URL: https://github.com/apache/beam/pull/34209#issuecomment-2708371923

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/34209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 56.28%. Comparing base [(`c1d0fa4`)](https://app.codecov.io/gh/apache/beam/commit/c1d0fa4f850f70a7dd5817227127fd9beadcc73e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f9d6400`)](https://app.codecov.io/gh/apache/beam/commit/f9d64009cf3a2aace49f4abc2a4273be544b0856?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 3 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #34209      +/-   ##
   ============================================
   - Coverage     56.28%   56.28%   -0.01%     
   + Complexity     3286     3284       -2     
   ============================================
     Files          1166     1166              
     Lines        178704   178704              
     Branches       3398     3398              
   ============================================
   - Hits         100591   100581      -10     
   - Misses        74860    74867       +7     
   - Partials       3253     3256       +3     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/34209/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [java](https://app.codecov.io/gh/apache/beam/pull/34209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.50% <ΓΈ> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/34209?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>πŸš€ New features to boost your workflow: </summary>
   
   - ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - πŸ“¦ [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34209:
URL: https://github.com/apache/beam/pull/34209#issuecomment-2707501795

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Skip some tests on Dataflow runners [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34209:
URL: https://github.com/apache/beam/pull/34209#issuecomment-2707395213

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @m-trieu for label java.
   R: @damondouglas for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1986062566


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,11 +619,9 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
-    if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
-    }
+    // Skipping dynamic destinations tests on Dataflow because of timing issues.
+    // These tests are more stable on the DirectRunner, where timing is less variable.
+    assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"));

Review Comment:
   @Abacn done
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Skip some tests on Dataflow runners [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34209:
URL: https://github.com/apache/beam/pull/34209#issuecomment-2706971137

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1985814302


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,11 +619,9 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
-    if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
-    }
+    // Skipping dynamic destinations tests on Dataflow because of timing issues.
+    // These tests are more stable on the DirectRunner, where timing is less variable.
+    assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"));

Review Comment:
   please use assumeFalse(message, ...) so from test report one could see why it is skipped



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Skip some tests on Dataflow runners [beam]

Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on PR #34209:
URL: https://github.com/apache/beam/pull/34209#issuecomment-2707500035

   R: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "akashorabek (via GitHub)" <gi...@apache.org>.
akashorabek commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1986062566


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,11 +619,9 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
-    if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
-    }
+    // Skipping dynamic destinations tests on Dataflow because of timing issues.
+    // These tests are more stable on the DirectRunner, where timing is less variable.
+    assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"));

Review Comment:
   @Abacn done
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1985744658


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,10 +618,10 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
+    // Skipping dynamic destinations tests on Dataflow because of timing issues.
+    // These tests are more stable on the DirectRunner, where timing is less variable.
     if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
+      assumeTrue("Skipping dynamic destinations tests on Dataflow", false);

Review Comment:
   Let's do `assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"))`. asumeTrue(false) sounds strange



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix PostCommit Java DataflowV2 [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #34209:
URL: https://github.com/apache/beam/pull/34209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org