You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2021/03/30 15:05:46 UTC
[DISCUSS] cordova-android 9.1.0 Minor Release
Does anyone have any reason to delay a cordova-android minor release (9.1.0)?
Any additional outstanding changes to land?
If not, I will start the release process shortly.
==Changes==
https://github.com/apache/cordova-android/compare/9.0.0...master
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by julio cesar sanchez <jc...@gmail.com>.
Yeah, but 9.0.0 was a major release, and the PR that updated gradle had
"major" on the title. So it was safer to bump versions.
El mar, 30 mar 2021 a las 19:49, Chris Brody (<ch...@gmail.com>)
escribió:
> FYI the build seemed to be red due to a timeout; I just restarted the
> build; hope it will be green.
>
>
> On Tue, Mar 30, 2021 at 1:46 PM Norman Breau <no...@nbsolutions.ca>
> wrote:
>
> > 9.0 used the latest available release at the time of the release with no
> > issue. Gradle 6.5 is just the minimum required version according to the
> > docs, they explicitly say 6.5+ is supported:
> > https://developer.android.com/studio/releases/gradle-plugin
> >
> > Because we were already on >= 6.5, I think this is still okay for
> release.
> >
> > On 2021-03-30 2:37 p.m., julio cesar sanchez wrote:
> > > I'm a little concerned about
> > > https://github.com/apache/cordova-android/pull/1174 and the previous
> one
> > > that also bumped the gradle version to 6.6.1. If you open the project
> on
> > > latest Android Studio, Android Studio recommends using Gradle 6.5, so
> not
> > > sure how safe it is to use the latest bleeding edge version instead of
> > the
> > > recommended and if that could cause problems with plugins that have
> > gradle
> > > files.
> > >
> > > But since it's a minor bump maybe I have no reason to be concerned.
> > >
> > > Other than that, looks good.
> > >
> > >
> > > El mar, 30 mar 2021 a las 17:06, Bryan Ellis (<er...@apache.org>)
> > escribió:
> > >
> > >> Does anyone have any reason to delay a cordova-android minor release
> > >> (9.1.0)?
> > >>
> > >> Any additional outstanding changes to land?
> > >>
> > >> If not, I will start the release process shortly.
> > >>
> > >>
> > >> ==Changes==
> > >>
> > >> https://github.com/apache/cordova-android/compare/9.0.0...master
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by Chris Brody <ch...@gmail.com>.
FYI the build seemed to be red due to a timeout; I just restarted the
build; hope it will be green.
On Tue, Mar 30, 2021 at 1:46 PM Norman Breau <no...@nbsolutions.ca> wrote:
> 9.0 used the latest available release at the time of the release with no
> issue. Gradle 6.5 is just the minimum required version according to the
> docs, they explicitly say 6.5+ is supported:
> https://developer.android.com/studio/releases/gradle-plugin
>
> Because we were already on >= 6.5, I think this is still okay for release.
>
> On 2021-03-30 2:37 p.m., julio cesar sanchez wrote:
> > I'm a little concerned about
> > https://github.com/apache/cordova-android/pull/1174 and the previous one
> > that also bumped the gradle version to 6.6.1. If you open the project on
> > latest Android Studio, Android Studio recommends using Gradle 6.5, so not
> > sure how safe it is to use the latest bleeding edge version instead of
> the
> > recommended and if that could cause problems with plugins that have
> gradle
> > files.
> >
> > But since it's a minor bump maybe I have no reason to be concerned.
> >
> > Other than that, looks good.
> >
> >
> > El mar, 30 mar 2021 a las 17:06, Bryan Ellis (<er...@apache.org>)
> escribió:
> >
> >> Does anyone have any reason to delay a cordova-android minor release
> >> (9.1.0)?
> >>
> >> Any additional outstanding changes to land?
> >>
> >> If not, I will start the release process shortly.
> >>
> >>
> >> ==Changes==
> >>
> >> https://github.com/apache/cordova-android/compare/9.0.0...master
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by Norman Breau <no...@nbsolutions.ca>.
9.0 used the latest available release at the time of the release with no
issue. Gradle 6.5 is just the minimum required version according to the
docs, they explicitly say 6.5+ is supported:
https://developer.android.com/studio/releases/gradle-plugin
Because we were already on >= 6.5, I think this is still okay for release.
On 2021-03-30 2:37 p.m., julio cesar sanchez wrote:
> I'm a little concerned about
> https://github.com/apache/cordova-android/pull/1174 and the previous one
> that also bumped the gradle version to 6.6.1. If you open the project on
> latest Android Studio, Android Studio recommends using Gradle 6.5, so not
> sure how safe it is to use the latest bleeding edge version instead of the
> recommended and if that could cause problems with plugins that have gradle
> files.
>
> But since it's a minor bump maybe I have no reason to be concerned.
>
> Other than that, looks good.
>
>
> El mar, 30 mar 2021 a las 17:06, Bryan Ellis (<er...@apache.org>) escribió:
>
>> Does anyone have any reason to delay a cordova-android minor release
>> (9.1.0)?
>>
>> Any additional outstanding changes to land?
>>
>> If not, I will start the release process shortly.
>>
>>
>> ==Changes==
>>
>> https://github.com/apache/cordova-android/compare/9.0.0...master
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by julio cesar sanchez <jc...@gmail.com>.
I'm a little concerned about
https://github.com/apache/cordova-android/pull/1174 and the previous one
that also bumped the gradle version to 6.6.1. If you open the project on
latest Android Studio, Android Studio recommends using Gradle 6.5, so not
sure how safe it is to use the latest bleeding edge version instead of the
recommended and if that could cause problems with plugins that have gradle
files.
But since it's a minor bump maybe I have no reason to be concerned.
Other than that, looks good.
El mar, 30 mar 2021 a las 17:06, Bryan Ellis (<er...@apache.org>) escribió:
> Does anyone have any reason to delay a cordova-android minor release
> (9.1.0)?
>
> Any additional outstanding changes to land?
>
> If not, I will start the release process shortly.
>
>
> ==Changes==
>
> https://github.com/apache/cordova-android/compare/9.0.0...master
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by julio cesar sanchez <jc...@gmail.com>.
I've seen that Bryant sent a few PRs reverting gradle related dependencies.
I only meant gradle wrapper, not everything else, and it's because Android
Studio automatically updates to 6.5 instead of updating to the latest
version.
In Capacitor we have had problems when users have updated the wrapper, but
not with the gradle plugin or google services plugin (at least that I
remember)
El mié, 31 mar 2021 a las 2:57, Jesse (<pu...@gmail.com>) escribió:
> +1 to moving ahead with 9.1.0, I think this is correctly identified as a
> minor.
>
>
> On Tue, Mar 30, 2021 at 2:51 PM <ra...@gmail.com> wrote:
>
> > It would be great if we could include
> > https://github.com/apache/cordova-android/pull/1101 in this release.
> >
> > It is just a pure refactoring/non-functional change PR but it sure would
> be
> > great to merge and release it before it gets stale.
> >
> > I would have no concerns merging it as is, even without reviews, since I
> am
> > confident it is an improvement in code quality. So we would not need to
> > delay the release.
> >
> > What do you think?
> >
> > Bryan Ellis <er...@apache.org> schrieb am Di., 30. März 2021, 17:06:
> >
> > > Does anyone have any reason to delay a cordova-android minor release
> > > (9.1.0)?
> > >
> > > Any additional outstanding changes to land?
> > >
> > > If not, I will start the release process shortly.
> > >
> > >
> > > ==Changes==
> > >
> > > https://github.com/apache/cordova-android/compare/9.0.0...master
> >
>
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by Jesse <pu...@gmail.com>.
+1 to moving ahead with 9.1.0, I think this is correctly identified as a
minor.
On Tue, Mar 30, 2021 at 2:51 PM <ra...@gmail.com> wrote:
> It would be great if we could include
> https://github.com/apache/cordova-android/pull/1101 in this release.
>
> It is just a pure refactoring/non-functional change PR but it sure would be
> great to merge and release it before it gets stale.
>
> I would have no concerns merging it as is, even without reviews, since I am
> confident it is an improvement in code quality. So we would not need to
> delay the release.
>
> What do you think?
>
> Bryan Ellis <er...@apache.org> schrieb am Di., 30. März 2021, 17:06:
>
> > Does anyone have any reason to delay a cordova-android minor release
> > (9.1.0)?
> >
> > Any additional outstanding changes to land?
> >
> > If not, I will start the release process shortly.
> >
> >
> > ==Changes==
> >
> > https://github.com/apache/cordova-android/compare/9.0.0...master
>
Re: [DISCUSS] cordova-android 9.1.0 Minor Release
Posted by ra...@gmail.com.
It would be great if we could include
https://github.com/apache/cordova-android/pull/1101 in this release.
It is just a pure refactoring/non-functional change PR but it sure would be
great to merge and release it before it gets stale.
I would have no concerns merging it as is, even without reviews, since I am
confident it is an improvement in code quality. So we would not need to
delay the release.
What do you think?
Bryan Ellis <er...@apache.org> schrieb am Di., 30. März 2021, 17:06:
> Does anyone have any reason to delay a cordova-android minor release
> (9.1.0)?
>
> Any additional outstanding changes to land?
>
> If not, I will start the release process shortly.
>
>
> ==Changes==
>
> https://github.com/apache/cordova-android/compare/9.0.0...master