You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2006/02/10 23:19:58 UTC

Another interesing warning

subversion\mod_dav_svn\repos.c(1327) : warning C4244: '=' : conversion from 'double ' to 'float ', possible loss of data


Yes, atof() returns a double. We should either cast this explicitly, or 
make result->quality a double, too.

-- Brane


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Another interesing warning

Posted by Daniel Rall <dl...@collab.net>.
On Sat, 11 Feb 2006, Branko Čibej wrote:

> subversion\mod_dav_svn\repos.c(1327) : warning C4244: '=' : conversion from 
> 'double ' to 'float ', possible loss of data
> 
> Yes, atof() returns a double. We should either cast this explicitly, or 
> make result->quality a double, too.

result->quality doesn't need a double's precision, so I've cast the
return value of atof() to a float in r18428.
--

Daniel Rall