You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/07/13 08:20:23 UTC
Review Request 67906: Updated tox usage in mesos-style.py to run in
support virtualenv.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67906/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Eric Chung, and Kevin Klues.
Bugs: MESOS-9073
https://issues.apache.org/jira/browse/MESOS-9073
Repository: mesos
Description
-------
Updated tox usage in mesos-style.py to run in support virtualenv.
Diffs
-----
support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43
support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5
Diff: https://reviews.apache.org/r/67906/diff/1/
Testing
-------
Used `mesos-style` to check that tox was correctly running.
Thanks,
Armand Grillet
Re: Review Request 67906: Updated tox usage in mesos-style.py to run
in support virtualenv.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67906/#review206073
-----------------------------------------------------------
Ship it!
I've changed some small stylistic things in the commit before pushing it. Please see the commit logs for details.
- Kevin Klues
On July 13, 2018, 8:20 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67906/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 8:20 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Eric Chung, and Kevin Klues.
>
>
> Bugs: MESOS-9073
> https://issues.apache.org/jira/browse/MESOS-9073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tox usage in mesos-style.py to run in support virtualenv.
>
>
> Diffs
> -----
>
> support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43
> support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5
>
>
> Diff: https://reviews.apache.org/r/67906/diff/3/
>
>
> Testing
> -------
>
> Used `mesos-style` to check that tox was correctly running.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 67906: Updated tox usage in mesos-style.py to run
in support virtualenv.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67906/#review206042
-----------------------------------------------------------
PASS: Mesos patch 67906 was successfully built and tested.
Reviews applied: `['67906']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1916/mesos-review-67906
- Mesos Reviewbot Windows
On July 13, 2018, 8:20 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67906/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 8:20 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Eric Chung, and Kevin Klues.
>
>
> Bugs: MESOS-9073
> https://issues.apache.org/jira/browse/MESOS-9073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tox usage in mesos-style.py to run in support virtualenv.
>
>
> Diffs
> -----
>
> support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43
> support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5
>
>
> Diff: https://reviews.apache.org/r/67906/diff/2/
>
>
> Testing
> -------
>
> Used `mesos-style` to check that tox was correctly running.
>
>
> Thanks,
>
> Armand Grillet
>
>