[GitHub] [arrow] Dandandan commented on a change in pull request #9991: ARROW-12335: [Rust] [Ballista] Use latest DataFusion

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #9991:
URL: https://github.com/apache/arrow/pull/9991#discussion_r613394563



##########
File path: rust/ballista/rust/Cargo.toml
##########
@@ -25,6 +25,6 @@ members = [
     "scheduler",
 ]
 
-[profile.release]
-lto = true
-codegen-units = 1
+#[profile.release]

Review comment:
       It would really be convenient for this to have this feature https://github.com/rust-lang/cargo/issues/6988 as I agree if you just want to run it with "reasonable" performance it shouldn't take ages to compile Ballista. In my experience it roughly 2x as long for project to build with lto (maybe worse when you compare it with incremental builds).
   
   It is possible to do via flags as well, but earlier this didn't work because of the structure of the Ballista projects (multiple binaries per crate as far as I remember), maybe we can just temporary remove this (and be a bit slower) and see if we can enable it in a different way.
   Another route I saw is just appending `lto = true` in a build script when creating binaries.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org