You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/11/06 17:57:57 UTC
[PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
potiuk opened a new pull request, #43763:
URL: https://github.com/apache/airflow/pull/43763
The AIRFLOW_V_2_8_PLUS is not needed as min airflow version already is 2.8.0+.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831503815
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
Maybe we should change the conditions to AIRFLOW_LESS_THAN_2_8 ... then probably some of the conditions would be easier to read :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831498187
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
Previousely the condition was skipif (not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,) = run only in 2.8. Yes. I know. Not obvious :)
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
Previousely the condition was skipif (not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS) = run only in 2.8. Yes. I know. Not obvious :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43763:
URL: https://github.com/apache/airflow/pull/43763#issuecomment-2461205488
Failing tests should be fixed after https://github.com/apache/airflow/pull/43771 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831491596
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
```suggestion
reason="This test checks serialization only in 2.9 conditions",
)
def test_serialize_timetable_2_9():
```
##########
contributing-docs/testing/unit_tests.rst:
##########
@@ -1173,10 +1173,10 @@ are not part of the public API. We deal with it in one of the following ways:
.. code-block:: python
- from tests_common.test_utils.compat import AIRFLOW_V_2_8_PLUS
+ from tests_common.test_utils.compat import AIRFLOW_V_2_9_PLUS
- @pytest.mark.skipif(not AIRFLOW_V_2_8_PLUS, reason="The tests should be skipped for Airflow < 2.8")
+ @pytest.mark.skipif(not AIRFLOW_V_2_9_PLUS, reason="The tests should be skipped for Airflow < 2.9")
def some_test_that_only_works_for_airflow_2_8_plus():
Review Comment:
```suggestion
def some_test_that_only_works_for_airflow_2_9_plus():
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43763:
URL: https://github.com/apache/airflow/pull/43763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831511516
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
Oh I see, my bad. I think it is good enough as is, I just read it too quickly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831496114
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
No - that's ok This test is run in 2.8 only. It has `skipif v2-9-plus` - so it only runs for 2.8 now - and we should remove it when we set min-airflow==2.9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831498187
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
Previousely the condition was (not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,) = run only in 2.8. Yes. I know. Not obvious :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43763:
URL: https://github.com/apache/airflow/pull/43763#discussion_r1831504209
##########
providers/tests/openlineage/plugins/test_utils.py:
##########
@@ -428,7 +427,7 @@ def test_serialize_timetable_2_9():
@pytest.mark.skipif(
- not AIRFLOW_V_2_8_PLUS or AIRFLOW_V_2_9_PLUS,
+ AIRFLOW_V_2_9_PLUS,
reason="This test checks serialization only in 2.8 conditions",
)
def test_serialize_timetable_2_8():
Review Comment:
(and I am not joking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIRFLOW_V_2_8_PLUS for provider's compatibility tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43763:
URL: https://github.com/apache/airflow/pull/43763#issuecomment-2460435091
Extracted from #43556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org