You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/24 06:14:22 UTC
[GitHub] [druid] jasonk000 edited a comment on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging
jasonk000 edited a comment on pull request #12097:
URL: https://github.com/apache/druid/pull/12097#issuecomment-1000674887
Some extra data, ..
With reference to the TaskQueue-Manager thread, a capture with info enabled:
With respect to this thread only, the `TaskRunner::shutdown` call is 82% of CPU in the `manage()` loop, and, the useful part of the loop, `findWorkerRunningTask` consumes ~18%, the rest is logging related. By (1) turning off INFO logging on this path, and (2) avoiding the `StringUtils.format()` call, we get approx 4x more capacity through the `TaskQueue-Manager` thread.
In other words, if you take the image just above ^, and eliminate the `Logger::info` and `StringUtils::format` paths, it opens a lot of capacity through this loop.
This becomes more obvious when coupled to #12096 and the yet-to-be-raised PR to reduce contention on the TaskQueue loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org