[GitHub] [beam] johnjcasey commented on a diff in pull request #26925: Integrating 4MC compression with Apache Beam

["johnjcasey (via GitHub)" <gi...@apache.org>]

johnjcasey commented on code in PR #26925:
URL: https://github.com/apache/beam/pull/26925#discussion_r1213459173


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Compression.java:
##########
@@ -240,8 +244,66 @@ public WritableByteChannel writeCompressed(WritableByteChannel channel) throws I
       return Channels.newChannel(
           new SnappyCompressorOutputStream(Channels.newOutputStream(channel), uncompressedSize));
     }
+  },
+
+  /** Four MC Compression Splittable compressed file format leveraging LZ4
+   * Uses LZ4 Fast Compression*/
+  MC4_FAST(".4mc", ".4mc") {

Review Comment:
   can you show your experiments verifying that many types with the same exception doesn't break?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org