You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2008/10/08 13:00:28 UTC
TRINIDAD-930
Hi,
I think that TRINIDAD-930 doesn't make sense.
I'd expect these editable value holdrs need to be in a form...
I am fine w/ *closing* this issue.
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: TRINIDAD-930
Posted by Matthias Wessendorf <ma...@apache.org>.
Martin,
please take a look here:
http://svn.apache.org/viewvc?view=rev&revision=703097
-M
On Wed, Oct 8, 2008 at 2:57 PM, Martin Kočí <Ma...@aura.cz> wrote:
>
> Ah, I see.
>
> Thanks.
>
> Matthias Wessendorf píše v St 08. 10. 2008 v 14:16 +0200:
>> in the "getConvertedValue(...)" we call internally __getIndex() (if
>> valuePassThru:false)
>>
>> and this function treats "" as -1
>>
>> see:
>> static int __getIndex(
>> Object submittedValue,
>> List<SelectItem> selectItems)
>> {
>> if ("".equals(submittedValue))
>> return -1;
>>
>> -M
>>
>> On Wed, Oct 8, 2008 at 1:54 PM, Martin Kočí <Ma...@aura.cz> wrote:
>> > Ok,
>> >
>> > we sovled this with a custom renderer.
>> >
>> > But consider that other h:select* or tr:select* have not this issue.
>> >
>> > And can you please put a comment in
>> > SimpleSelectOneRenderer.getSubmittedValue(FacesContext, UIComponent,
>> > String) method - I dont understand why it contains such code:
>> >
>> > Object submittedValue = super.getSubmittedValue(context,
>> > component,
>> > clientId);
>> > if (submittedValue == null)
>> > submittedValue = "";
>> >
>> > return submittedValue;
>> >
>> >
>> >
>> > Regards,
>> >
>> > Martin
>> >
>> >
>> > Matthias Wessendorf píše v St 08. 10. 2008 v 13:00 +0200:
>> >> Hi,
>> >>
>> >> I think that TRINIDAD-930 doesn't make sense.
>> >> I'd expect these editable value holdrs need to be in a form...
>> >>
>> >> I am fine w/ *closing* this issue.
>> >>
>> >> -M
>> >>
>> >
>> >
>>
>>
>>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: TRINIDAD-930
Posted by Martin Kočí <Ma...@aura.cz>.
Ah, I see.
Thanks.
Matthias Wessendorf píše v St 08. 10. 2008 v 14:16 +0200:
> in the "getConvertedValue(...)" we call internally __getIndex() (if
> valuePassThru:false)
>
> and this function treats "" as -1
>
> see:
> static int __getIndex(
> Object submittedValue,
> List<SelectItem> selectItems)
> {
> if ("".equals(submittedValue))
> return -1;
>
> -M
>
> On Wed, Oct 8, 2008 at 1:54 PM, Martin Kočí <Ma...@aura.cz> wrote:
> > Ok,
> >
> > we sovled this with a custom renderer.
> >
> > But consider that other h:select* or tr:select* have not this issue.
> >
> > And can you please put a comment in
> > SimpleSelectOneRenderer.getSubmittedValue(FacesContext, UIComponent,
> > String) method - I dont understand why it contains such code:
> >
> > Object submittedValue = super.getSubmittedValue(context,
> > component,
> > clientId);
> > if (submittedValue == null)
> > submittedValue = "";
> >
> > return submittedValue;
> >
> >
> >
> > Regards,
> >
> > Martin
> >
> >
> > Matthias Wessendorf píše v St 08. 10. 2008 v 13:00 +0200:
> >> Hi,
> >>
> >> I think that TRINIDAD-930 doesn't make sense.
> >> I'd expect these editable value holdrs need to be in a form...
> >>
> >> I am fine w/ *closing* this issue.
> >>
> >> -M
> >>
> >
> >
>
>
>
Re: TRINIDAD-930
Posted by Matthias Wessendorf <ma...@apache.org>.
in the "getConvertedValue(...)" we call internally __getIndex() (if
valuePassThru:false)
and this function treats "" as -1
see:
static int __getIndex(
Object submittedValue,
List<SelectItem> selectItems)
{
if ("".equals(submittedValue))
return -1;
-M
On Wed, Oct 8, 2008 at 1:54 PM, Martin Kočí <Ma...@aura.cz> wrote:
> Ok,
>
> we sovled this with a custom renderer.
>
> But consider that other h:select* or tr:select* have not this issue.
>
> And can you please put a comment in
> SimpleSelectOneRenderer.getSubmittedValue(FacesContext, UIComponent,
> String) method - I dont understand why it contains such code:
>
> Object submittedValue = super.getSubmittedValue(context,
> component,
> clientId);
> if (submittedValue == null)
> submittedValue = "";
>
> return submittedValue;
>
>
>
> Regards,
>
> Martin
>
>
> Matthias Wessendorf píše v St 08. 10. 2008 v 13:00 +0200:
>> Hi,
>>
>> I think that TRINIDAD-930 doesn't make sense.
>> I'd expect these editable value holdrs need to be in a form...
>>
>> I am fine w/ *closing* this issue.
>>
>> -M
>>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: TRINIDAD-930
Posted by Martin Kočí <Ma...@aura.cz>.
Ok,
we sovled this with a custom renderer.
But consider that other h:select* or tr:select* have not this issue.
And can you please put a comment in
SimpleSelectOneRenderer.getSubmittedValue(FacesContext, UIComponent,
String) method - I dont understand why it contains such code:
Object submittedValue = super.getSubmittedValue(context,
component,
clientId);
if (submittedValue == null)
submittedValue = "";
return submittedValue;
Regards,
Martin
Matthias Wessendorf píše v St 08. 10. 2008 v 13:00 +0200:
> Hi,
>
> I think that TRINIDAD-930 doesn't make sense.
> I'd expect these editable value holdrs need to be in a form...
>
> I am fine w/ *closing* this issue.
>
> -M
>