You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Randall Leeds (JIRA)" <ji...@apache.org> on 2010/12/21 08:57:01 UTC
[jira] Created: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
replicator doesn't respect .ini settings for http sources
---------------------------------------------------------
Key: COUCHDB-992
URL: https://issues.apache.org/jira/browse/COUCHDB-992
Project: CouchDB
Issue Type: Bug
Components: Replication
Affects Versions: 1.0.1
Reporter: Randall Leeds
Fix For: 1.0.2, 1.1
The replication reader ignores the settings in the config file.
More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973636#action_12973636 ]
Filipe Manana commented on COUCHDB-992:
---------------------------------------
Thanks Randall.
In fact I would just remove the sessions and pipeline size options from the #http_db record in couch_bd.hrl. They're useless there.
Can you update the patch?
thanks
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana closed COUCHDB-992.
---------------------------------
Resolution: Fixed
Applied to trunk, 1.0.x and 1.1.x.
Thanks
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Assignee: Filipe Manana
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch, COUCHDB-992-fdmanana.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-992:
----------------------------------
Attachment: 0001-respect-replicator-config-settings-COUCHDB-992.patch
Here's the patch.
couch_rep_reader no longer sets these settings when init is called, leaving it to the http_db record to hold the correct defaults.
I changed the #http_db record to use the defaults that had been forced by couch_rep_reader before. I thought this was safest. Since each replication between two hosts will open as many as 100 requests at a time any change which lowered the default value of (sessions x pipeline_size) could cause user's replications to experience a regression of surprising back-off or even failure.
Each replication reader registers on config changes too, so it should be possible to change how many sessions continuous or long-running replications are using without restarting them.
Thankfully, I think most of this goes away with the new replicator, but since that's not default yet I propose this for backport to 1.0.2 and 1.1.
Unfortunately, I actually have a situation where a pre-release xulrunner-devel on my system is preventing CouchDB from compiling. I'll have to open a separate ticket for that, but please forgive me if this patch contains some tiny syntax error. I wanted to file it before I forgot (again).
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana reassigned COUCHDB-992:
-------------------------------------
Assignee: Filipe Manana
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Assignee: Filipe Manana
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch, COUCHDB-992-fdmanana.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974290#action_12974290 ]
Randall Leeds commented on COUCHDB-992:
---------------------------------------
Looks great. No complaints.
+1 on committing to both 1.0.2 and 1.1.
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Assignee: Filipe Manana
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch, COUCHDB-992-fdmanana.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-992) replicator doesn't respect .ini
settings for http sources
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-992:
----------------------------------
Attachment: COUCHDB-992-fdmanana.patch
Looking more carefully at this, the setup of the number of http connections and pipeline size should be done in couch_rep_httpc:db_exists/3, which is called by couch_rep:open_db/3. Conceptually it's a more appropriate place to do it and it applies the settings either to a source or remote database (or both).
Also, removed those settings from the #http_db record definition, to avoid setting new pipeline values on every request the replicator sends.
I also noticed now a small typo in your patch Randall:
+ ("replicator", "max_http_piple_size", MaxPipe) ->
If nobody has an objection against the proposed patch, I'll commit it by tomorrow.
cheers
> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
> Key: COUCHDB-992
> URL: https://issues.apache.org/jira/browse/COUCHDB-992
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Affects Versions: 1.0.1
> Reporter: Randall Leeds
> Fix For: 1.0.2, 1.1
>
> Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch, COUCHDB-992-fdmanana.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.