You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "yma11 (via GitHub)" <gi...@apache.org> on 2024/05/06 13:20:37 UTC
[PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
yma11 opened a new pull request, #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623
## What changes were proposed in this pull request?
In Spark 3.5, there are some new added UTs vs Spark3.4 which haven't been added in Gluten yet. In this PR, we ported the ones under spark/sql but excluding folders like streaming, execution/command, execution/benchmark.
(Fixes: \#5622)
## How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
Posted by "yma11 (via GitHub)" <gi...@apache.org>.
yma11 commented on PR #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623#issuecomment-2097459574
@zhouyuan Please help review this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623#issuecomment-2097847861
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5623_time.csv</font></td>
<td><font color=#000000>log/native_master_05_06_2024_72e787c64_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>35.97</font></td>
<td><font color=#F92663>36.58</font></td>
<td><font color=#F92663>0.610</font></td>
<td><font color=#F92663>101.69%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>23.67</font></td>
<td><font color=#F92663>23.74</font></td>
<td><font color=#F92663>0.066</font></td>
<td><font color=#F92663>100.28%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>35.50</font></td>
<td><font color=#F92663>38.97</font></td>
<td><font color=#F92663>3.463</font></td>
<td><font color=#F92663>109.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>37.78</font></td>
<td><font color=#F92663>38.09</font></td>
<td><font color=#F92663>0.308</font></td>
<td><font color=#F92663>100.82%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>69.64</font></td>
<td><font color=#6F9915>68.56</font></td>
<td><font color=#6F9915>-1.082</font></td>
<td><font color=#6F9915>98.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>7.48</font></td>
<td><font color=#6F9915>6.78</font></td>
<td><font color=#6F9915>-0.696</font></td>
<td><font color=#6F9915>90.70%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>84.20</font></td>
<td><font color=#6F9915>83.29</font></td>
<td><font color=#6F9915>-0.910</font></td>
<td><font color=#6F9915>98.92%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>86.17</font></td>
<td><font color=#F92663>87.34</font></td>
<td><font color=#F92663>1.171</font></td>
<td><font color=#F92663>101.36%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>120.44</font></td>
<td><font color=#F92663>122.36</font></td>
<td><font color=#F92663>1.927</font></td>
<td><font color=#F92663>101.60%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>44.69</font></td>
<td><font color=#F92663>46.26</font></td>
<td><font color=#F92663>1.569</font></td>
<td><font color=#F92663>103.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.36</font></td>
<td><font color=#F92663>20.36</font></td>
<td><font color=#F92663>0.001</font></td>
<td><font color=#F92663>100.00%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>28.40</font></td>
<td><font color=#6F9915>27.48</font></td>
<td><font color=#6F9915>-0.924</font></td>
<td><font color=#6F9915>96.75%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>56.43</font></td>
<td><font color=#6F9915>54.80</font></td>
<td><font color=#6F9915>-1.624</font></td>
<td><font color=#6F9915>97.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>23.81</font></td>
<td><font color=#6F9915>20.20</font></td>
<td><font color=#6F9915>-3.617</font></td>
<td><font color=#6F9915>84.81%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>30.07</font></td>
<td><font color=#F92663>30.34</font></td>
<td><font color=#F92663>0.265</font></td>
<td><font color=#F92663>100.88%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>13.63</font></td>
<td><font color=#F92663>15.88</font></td>
<td><font color=#F92663>2.247</font></td>
<td><font color=#F92663>116.48%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>103.76</font></td>
<td><font color=#6F9915>101.90</font></td>
<td><font color=#6F9915>-1.857</font></td>
<td><font color=#6F9915>98.21%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>146.02</font></td>
<td><font color=#F92663>146.06</font></td>
<td><font color=#F92663>0.035</font></td>
<td><font color=#F92663>100.02%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>16.12</font></td>
<td><font color=#6F9915>14.65</font></td>
<td><font color=#6F9915>-1.462</font></td>
<td><font color=#6F9915>90.93%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>27.13</font></td>
<td><font color=#6F9915>26.35</font></td>
<td><font color=#6F9915>-0.788</font></td>
<td><font color=#6F9915>97.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>279.33</font></td>
<td><font color=#F92663>291.97</font></td>
<td><font color=#F92663>12.633</font></td>
<td><font color=#F92663>104.52%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.84</font></td>
<td><font color=#F92663>15.01</font></td>
<td><font color=#F92663>0.173</font></td>
<td><font color=#F92663>101.16%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1305.47</font></td>
<td><font color=#F92663>1316.98</font></td>
<td><font color=#F92663>11.509</font></td>
<td><font color=#F92663>100.88%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623#issuecomment-2096007619
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5622] Add new added Spark3.5 UTs in Gluten [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5623:
URL: https://github.com/apache/incubator-gluten/pull/5623#issuecomment-2096007040
https://github.com/apache/incubator-gluten/issues/5622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org