You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/11/05 05:48:50 UTC
[jira] [Commented] (THRIFT-2704) generated oneway functions encode
as T_CALL not T_ONEWAY
[ https://issues.apache.org/jira/browse/THRIFT-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197519#comment-14197519 ]
Hudson commented on THRIFT-2704:
--------------------------------
SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2704 - compiler: T_ONEWAY type used for oneway methods instead of T_CALL (jensg: rev a86886e77d355ec7523f0b9041f9f0ac03e4dd33)
* compiler/cpp/src/generate/t_as3_generator.cc
* lib/nodejs/lib/thrift/protocol.js
* lib/cpp/test/AllProtocolTests.tcc
* compiler/cpp/src/generate/t_cocoa_generator.cc
* compiler/cpp/src/generate/t_delphi_generator.cc
* lib/py/src/protocol/TCompactProtocol.py
* compiler/cpp/src/generate/t_js_generator.cc
* lib/rb/lib/thrift/protocol/compact_protocol.rb
* lib/cpp/src/thrift/protocol/TCompactProtocol.tcc
* lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
* compiler/cpp/src/generate/t_hs_generator.cc
* lib/hs/src/Thrift/Protocol/Compact.hs
* compiler/cpp/src/generate/t_py_generator.cc
* lib/go/thrift/compact_protocol.go
* compiler/cpp/src/generate/t_php_generator.cc
* compiler/cpp/src/generate/t_go_generator.cc
* lib/csharp/src/Protocol/TCompactProtocol.cs
* doc/specs/thrift-protocol-spec.md
* lib/cpp/src/thrift/processor/PeekProcessor.cpp
* compiler/cpp/src/generate/t_perl_generator.cc
* compiler/cpp/src/generate/t_csharp_generator.cc
* compiler/cpp/src/generate/t_lua_generator.cc
* compiler/cpp/src/generate/t_cpp_generator.cc
* lib/php/lib/Thrift/Protocol/TCompactProtocol.php
* compiler/cpp/src/generate/t_java_generator.cc
* compiler/cpp/src/generate/t_ocaml_generator.cc
* lib/hs/src/Thrift/Types.hs
* lib/cpp/src/thrift/processor/StatsProcessor.h
* lib/cpp/src/thrift/protocol/TCompactProtocol.h
* compiler/cpp/src/generate/t_c_glib_generator.cc
* lib/d/src/thrift/protocol/compact.d
* compiler/cpp/src/generate/t_javame_generator.cc
* lib/rb/ext/compact_protocol.c
> generated oneway functions encode as T_CALL not T_ONEWAY
> --------------------------------------------------------
>
> Key: THRIFT-2704
> URL: https://issues.apache.org/jira/browse/THRIFT-2704
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.9.1
> Reporter: Konrad Grochowski
> Assignee: Jens Geyer
>
> Steven Varga wrote:
> {quote}
> Hi,
> the following service generates oneway RPC call flagged with T_CALL flag as
> opposed to expected T_ONEWAY; I need the T_ONEWAY flag to implement proper
> zero MQ message passing. Zero MQ message passing system differentiates
> between request - reply patterns and push - pull ones at socket level;
> Am I doing something wrong ?
> best,
> steve
> service foo {
> oneway void bar( 1:string value );
> }
> void fooClient::put( const std::string& value ) {
> send_bar( value ); // <- this is correct that recv_xxx is missing
> }
> // ----- incorrect or unreasoned T_CALL instead of T_ONEWAY
> void fooClient::send_bar(const std::string& value) {
> int32_t cseqid = 0;
> oprot_->writeMessageBegin("bar", ::apache::thrift::protocol::T_CALL,
> cseqid);
> ....
> }
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)