You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/19 06:56:37 UTC

[GitHub] [flink] KarmaGYZ commented on a diff in pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

KarmaGYZ commented on code in PR #17873:
URL: https://github.com/apache/flink/pull/17873#discussion_r876667835


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java:
##########
@@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, ObjectNode node) {
 
         node.put(CONTENTS, vertex.getOperatorDescription());
 
+        node.put(SLOT_SHARING_GROUP, vertex.getSlotSharingGroup());

Review Comment:
   Do we ensure the `slotSharingGroup` has been set properly before? If so, we can add a non-null check here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org