You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/06/26 09:41:41 UTC

Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Bugs: MESOS-2871
    https://issues.apache.org/jira/browse/MESOS-2871


Repository: mesos


Description
-------

Disabled fetcher cache test HttpCachedRecovery and added a TODO to debug its flakiness (MESOS-2871).


Diffs
-----

  src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 

Diff: https://reviews.apache.org/r/35917/diff/


Testing
-------


Thanks,

Bernd Mathiske


Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89475
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On June 26, 2015, 12:47 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35917/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 12:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-2871
>     https://issues.apache.org/jira/browse/MESOS-2871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disabled fetcher cache test HttpCachedRecovery and added a TODO to debug its flakiness (MESOS-2871).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 
> 
> Diff: https://reviews.apache.org/r/35917/diff/
> 
> 
> Testing
> -------
> 
> make check. Observed that the test is no longer active.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89477
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35917]

All tests passed.

- Mesos ReviewBot


On June 26, 2015, 7:47 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35917/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 7:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-2871
>     https://issues.apache.org/jira/browse/MESOS-2871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disabled fetcher cache test HttpCachedRecovery and added a TODO to debug its flakiness (MESOS-2871).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 
> 
> Diff: https://reviews.apache.org/r/35917/diff/
> 
> 
> Testing
> -------
> 
> make check. Observed that the test is no longer active.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89476
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On June 26, 2015, 3:47 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35917/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 3:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-2871
>     https://issues.apache.org/jira/browse/MESOS-2871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disabled fetcher cache test HttpCachedRecovery and added a TODO to debug its flakiness (MESOS-2871).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 
> 
> Diff: https://reviews.apache.org/r/35917/diff/
> 
> 
> Testing
> -------
> 
> make check. Observed that the test is no longer active.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/
-----------------------------------------------------------

(Updated June 26, 2015, 12:47 a.m.)


Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.


Changes
-------

tested


Bugs: MESOS-2871
    https://issues.apache.org/jira/browse/MESOS-2871


Repository: mesos


Description
-------

Disabled fetcher cache test HttpCachedRecovery and added a TODO to debug its flakiness (MESOS-2871).


Diffs
-----

  src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 

Diff: https://reviews.apache.org/r/35917/diff/


Testing (updated)
-------

make check. Observed that the test is no longer active.


Thanks,

Bernd Mathiske