You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/02/20 06:26:58 UTC

[PR] fix flaky JdbcProjectionTest [incubator-pekko-projection]

Roiocam opened a new pull request, #108:
URL: https://github.com/apache/incubator-pekko-projection/pull/108

   # Motivation
   
   solved: #104
   
   It is the same problem as #105.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix flaky JdbcProjectionTest [incubator-pekko-projection]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #108:
URL: https://github.com/apache/incubator-pekko-projection/pull/108#issuecomment-1953596766

   #103 break the CI check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix flaky JdbcProjectionTest [incubator-pekko-projection]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #108:
URL: https://github.com/apache/incubator-pekko-projection/pull/108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix flaky JdbcProjectionTest [incubator-pekko-projection]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-projection/pull/108#discussion_r1495301749


##########
jdbc/src/test/java/org/apache/pekko/projection/jdbc/JdbcProjectionTest.java:
##########
@@ -346,8 +346,9 @@ public void atLeastOnceShouldRestartFromPreviousOffset() {
            *
            * See https://github.com/akka/akka-projection/issues/462 for a possible solution.

Review Comment:
   Should we keep these comments or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org