[jira] [Commented] (TIKA-3826) Helm: use appVersion from Charts.yaml intsead of images.tag

["Lewis John McGibbney (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617298#comment-17617298 ] 

Lewis John McGibbney commented on TIKA-3826:
--------------------------------------------

[~hairmare] good suggestion. Please file a PR and tage me. i will be happy to review.
Thanks

> Helm: use appVersion from Charts.yaml intsead of images.tag
> -----------------------------------------------------------
>
>                 Key: TIKA-3826
>                 URL: https://issues.apache.org/jira/browse/TIKA-3826
>             Project: Tika
>          Issue Type: Bug
>          Components: helm
>    Affects Versions: 2.2.1
>            Reporter: Lucas Bickel
>            Priority: Major
>
> This is about the [tika Helm chart|https://github.com/apache/tika-helm].
> In `values.yaml` we currently have [this|https://github.com/apache/tika-helm/blob/492386471616713bddbc5851912acdd78bd87609/values.yaml#L25-L26]:
> {code:yaml}
> # Overrides the image tag whose default is the chart appVersion.
>   tag: "1.26"
> {code}
> This leads to {{ .Values.image.tag | default .Chart.AppVersion }} [in deployment.yaml|https://github.com/apache/tika-helm/blob/492386471616713bddbc5851912acdd78bd87609/templates/deployment.yaml#L52] being dead code.
> Currently the docs indicate that we should set {{image.tag}} during the deployment, skipping this step results in deploying a very outdated tika 1.26.
> My proposal for fixing this is to set the appVersion in {{Chart.yaml}} to the latest 2.4.1-full version and set the image.tag to an empty version so it defaults to the version from Chart.yaml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)