You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/25 15:55:42 UTC

Review Request 34651: Agent configs upgrade fails on upgrade 1.6.0 -> 2.0.1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34651/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11370
    https://issues.apache.org/jira/browse/AMBARI-11370


Repository: ambari


Description
-------

ambari-agent.ini config upgrade fails on upgrade from Ambari 1.6.0 -> 2.0.1.
(1.7 and 2.0 upgrade is fine)  
Impact: Server hostname is changed to the default 'localhost' and all other
custom configs are restored to defaults.  
Old configs are saved to backup, so user can restore it manually.

    
    
    Running Transaction
      Updating   : ambari-agent-2.0.1-45.x86_64                                                                                                                                                              1/2 
    #includedir /etc/sudoers.d
    Upgrading configs in /etc/ambari-agent/conf/ambari-agent.ini
    Values will be updated from /etc/ambari-agent/conf/ambari-agent.ini.old except the following list: [('heartbeat', 'dirs')]
    Traceback (most recent call last):
      File "/var/lib/ambari-agent/upgrade_agent_configs.py", line 44, in <module>
        agent_config.set(section, property_name, property_val)
      File "/usr/lib64/python2.6/ConfigParser.py", line 377, in set
        raise NoSectionError(section)
    ConfigParser.NoSectionError: No section: 'puppet'
      Cleanup    : ambari-agent-1.6.0-46.x86_64                                                                                                                                                              2/2 
      Verifying  : ambari-agent-2.0.1-45.x86_64                                                                                                                                                              1/2 
      Verifying  : ambari-agent-1.6.0-46.x86_64                                                                                                                                                              2/2 
    
    Updated:
      ambari-agent.x86_64 0:2.0.1-45                                                                                                                                                                             
    
    Complete!


Diffs
-----

  ambari-agent/conf/unix/upgrade_agent_configs.py 8b7be7a 

Diff: https://reviews.apache.org/r/34651/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 34651: Agent configs upgrade fails on upgrade 1.6.0 -> 2.0.1

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34651/#review85127
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Травень 25, 2015, 1:55 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34651/
> -----------------------------------------------------------
> 
> (Updated Травень 25, 2015, 1:55 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11370
>     https://issues.apache.org/jira/browse/AMBARI-11370
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ambari-agent.ini config upgrade fails on upgrade from Ambari 1.6.0 -> 2.0.1.
> (1.7 and 2.0 upgrade is fine)  
> Impact: Server hostname is changed to the default 'localhost' and all other
> custom configs are restored to defaults.  
> Old configs are saved to backup, so user can restore it manually.
> 
>     
>     
>     Running Transaction
>       Updating   : ambari-agent-2.0.1-45.x86_64                                                                                                                                                              1/2 
>     #includedir /etc/sudoers.d
>     Upgrading configs in /etc/ambari-agent/conf/ambari-agent.ini
>     Values will be updated from /etc/ambari-agent/conf/ambari-agent.ini.old except the following list: [('heartbeat', 'dirs')]
>     Traceback (most recent call last):
>       File "/var/lib/ambari-agent/upgrade_agent_configs.py", line 44, in <module>
>         agent_config.set(section, property_name, property_val)
>       File "/usr/lib64/python2.6/ConfigParser.py", line 377, in set
>         raise NoSectionError(section)
>     ConfigParser.NoSectionError: No section: 'puppet'
>       Cleanup    : ambari-agent-1.6.0-46.x86_64                                                                                                                                                              2/2 
>       Verifying  : ambari-agent-2.0.1-45.x86_64                                                                                                                                                              1/2 
>       Verifying  : ambari-agent-1.6.0-46.x86_64                                                                                                                                                              2/2 
>     
>     Updated:
>       ambari-agent.x86_64 0:2.0.1-45                                                                                                                                                                             
>     
>     Complete!
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/upgrade_agent_configs.py 8b7be7a 
> 
> Diff: https://reviews.apache.org/r/34651/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>