You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 09:05:29 UTC
[GitHub] [flink] zentol opened a new pull request #11616: [FLINK-16942][es]
Allow users to override http/transport type
zentol opened a new pull request #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616
Inverts the order in which the `Settings` are assembled so that users can override the http/transport type.
This should allow users to use the netty4 transport client if they wish to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11616:
[FLINK-16942][es] Allow users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157722770",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ed18352ec3e869bb9ae8fd73746792280777ce Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157722770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11616:
[FLINK-16942][es] Allow users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157722770",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750032",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ed18352ec3e869bb9ae8fd73746792280777ce Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157722770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977)
* 9c8b8da609f71799b8e21f813e1155d050a3165a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157750032) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11616:
[FLINK-16942][es] Allow users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157722770",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750032",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c8b8da609f71799b8e21f813e1155d050a3165a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157750032) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11616:
[FLINK-16942][es] Allow users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157722770",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750032",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c8b8da609f71799b8e21f813e1155d050a3165a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157750032) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11616: [FLINK-16942][es] Allow
users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607720987
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 07ed18352ec3e869bb9ae8fd73746792280777ce (Thu Apr 02 09:09:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11616: [FLINK-16942][es] Allow
users to override http/transport type
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11616:
[FLINK-16942][es] Allow users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157722770",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
}, {
"hash" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c8b8da609f71799b8e21f813e1155d050a3165a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ed18352ec3e869bb9ae8fd73746792280777ce Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157722770) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6977)
* 9c8b8da609f71799b8e21f813e1155d050a3165a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11616: [FLINK-16942][es] Allow
users to override http/transport type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11616: [FLINK-16942][es] Allow users to override http/transport type
URL: https://github.com/apache/flink/pull/11616#issuecomment-607727342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07ed18352ec3e869bb9ae8fd73746792280777ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ed18352ec3e869bb9ae8fd73746792280777ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services