[GitHub] [incubator-doris] imay commented on a change in pull request #2752: Add be bitmap udf

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2752: Add be bitmap udf 
URL: https://github.com/apache/incubator-doris/pull/2752#discussion_r366153397
 
 

 ##########
 File path: be/src/exprs/bitmap_function.cpp
 ##########
 @@ -465,6 +465,43 @@ StringVal BitmapFunctions::bitmap_from_string(FunctionContext* ctx, const String
     return result;
 }
 
+BooleanVal BitmapFunctions::bitmap_contains(FunctionContext *ctx, const StringVal &src, const IntVal &input) {
 
 Review comment:
   Because we don't have unsigned int, but the bit value can exceede the max int. Better use BigIntValue as bit index

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org