You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ivanandika98 (via GitHub)" <gi...@apache.org> on 2023/02/20 06:47:36 UTC
[GitHub] [ozone] ivanandika98 opened a new pull request, #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
ivanandika98 opened a new pull request, #4288:
URL: https://github.com/apache/ozone/pull/4288
## What changes were proposed in this pull request?
This fix excludes `StreamingOutput` related operations' spans to be closed in `TracingFilter` and only close after `StreamingOutput` callback (i.e. `GetBlock` and `ReadChunk`) has finished and the data has been written to the destination
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7064
## How was this patch tested?
Manual test in the docker-compose environment (with tracing enabled) and submitting AWS get-object request to S3G endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4288:
URL: https://github.com/apache/ozone/pull/4288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ivanandika98 commented on pull request #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
Posted by "ivanandika98 (via GitHub)" <gi...@apache.org>.
ivanandika98 commented on PR #4288:
URL: https://github.com/apache/ozone/pull/4288#issuecomment-1436425914
Hi @adoroszlai could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ivanandika98 commented on pull request #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
Posted by "ivanandika98 (via GitHub)" <gi...@apache.org>.
ivanandika98 commented on PR #4288:
URL: https://github.com/apache/ozone/pull/4288#issuecomment-1436632619
Hi @adoroszlai, thank you for the review. I completely agree with avoiding the need to call `TracingFilter` in the `ObjectEndpoint`. I think the solution makes the code more maintainable. Thank you for the suggestion.
I will double check the solution and push the change if there is no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4288:
URL: https://github.com/apache/ozone/pull/4288#issuecomment-1436636548
> I will double check the solution and push the change if there is no issue.
Thanks. Please note I have edited the proposed diff to make it more consistent with the existing implementation (i.e. also close/finish the scope/span from the request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ivanandika98 commented on pull request #4288: HDDS-7064. S3 get-object response emits tracing spans outside ObjectEndpoint#get
Posted by "ivanandika98 (via GitHub)" <gi...@apache.org>.
ivanandika98 commented on PR #4288:
URL: https://github.com/apache/ozone/pull/4288#issuecomment-1436747240
Hi @adoroszlai, I have applied the change. Could you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org