You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/15 20:09:23 UTC

[GitHub] [incubator-nuttx] spiriou opened a new pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

spiriou opened a new pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595


   ## Summary
   
   Fix epoll_wait() function:
   - struct epoll_event must be identical to struct pollfd because of current epoll_wait() implementation: 
   "rc = poll((FAR struct pollfd *)eph->evs, eph->occupied, timeout);"
   - epoll_wait() must loop until "maxevents" to fill output evs array
   
   ## Impact
   
   Is epoll API used by anyone ?
   
   ## Testing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] spiriou commented on pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595#issuecomment-674496155


   @anchao yes indeed, there is a conflit regarding the modification of sys/epoll.h.
   The modification from #1582 looks good so I can rebase on top of your patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595#issuecomment-677715108


   @xiaoxiang781216 could you take a look here please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595#issuecomment-674479682


   It seems that some of part conflict with the https://github.com/apache/incubator-nuttx/pull/1582


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595#issuecomment-675245599


   @spiriou could you rebase your patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1595: fs/vfs/fs_epoll: fix epoll_wait function

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1595:
URL: https://github.com/apache/incubator-nuttx/pull/1595#issuecomment-677779399


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org